Skip to content

Conversation

@qnixsynapse
Copy link
Contributor

@qnixsynapse qnixsynapse commented Jul 28, 2025

Describe Your Changes

Previously, the autoUnload flag was not being updated when set via config, causing models to be auto-unloaded regardless of the intended behavior. This patch ensures the setting is respected at runtime.

Thanks @louis-menlo for the help!


Important

Fixes issue in index.ts where autoUnload was not updated from config, ensuring it reflects the auto_unload setting at runtime.

  • Behavior:
    • Fixes issue where autoUnload was not updated from config in onSettingUpdate() in index.ts.
    • Ensures autoUnload reflects the auto_unload setting at runtime.

This description was created by Ellipsis for 840a3e7. You can customize this summary. It will automatically update as commits are pushed.

Previously, the `autoUnload` flag was not being updated when set via config,
causing models to be auto-unloaded regardless of the intended behavior.
This patch ensures the setting is respected at runtime.
@qnixsynapse qnixsynapse merged commit fa896b3 into release/v0.6.6 Jul 28, 2025
11 checks passed
@qnixsynapse qnixsynapse deleted the fix/my_stupidity branch July 28, 2025 13:47
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 28, 2025
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added this to the v0.6.7 milestone Jul 28, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 840a3e7 in 2 minutes and 7 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_PQmQdHPcT37YNLUc

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 38.72%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants