🐛fix: get system info and system usage

[urmauur]

Describe Your Changes

This pull request enhances the hardware settings and system monitor functionality by improving data fetching, error handling, and user experience. Key changes include adding loading states for hardware information, refining system usage polling, and improving code structure for better readability and maintainability.

Hardware Settings Enhancements:

1. Loading State for Hardware Information:

   • Introduced an isLoading state and a loading spinner to display a message while hardware information is being fetched. [1] [2] [3]

2. Improved Data Fetching:

   • Added a new getHardwareInfo service to fetch hardware details alongside system usage during the initial load. Errors are now logged for better debugging. [1] [2]

3. Error Handling for Polling:

   • Enhanced error handling for periodic system usage polling to log failures without disrupting the UI.

System Monitor Enhancements:

1. Polling System Usage:
   • Added a periodic polling mechanism to fetch system usage data every 5 seconds, with error handling to log failures. [1] [2]

Code Quality Improvements:

1. Refactored Memory Usage Calculation:
   • Improved readability of memory usage calculation by reformatting code for better clarity.

Fixes Issues

• Closes #
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Enhances system monitoring and hardware settings with loading states, improved data fetching, error handling, and periodic polling.

• Behavior:
  • Adds isLoading state and loading spinner in hardware.tsx to indicate hardware info fetching.
  • Introduces getHardwareInfo service in hardware.tsx for fetching hardware details.
  • Implements periodic polling every 5 seconds for system usage in hardware.tsx and system-monitor.tsx.
  • Logs errors during hardware info and system usage fetching in hardware.tsx and system-monitor.tsx.
• Code Quality:
  • Refactors memory usage calculation in system-monitor.tsx for clarity.

^{This description was created by for 1463266. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 1463266 in 1 minute and 55 seconds. Click for details.

• Reviewed 479 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/routes/settings/hardware.tsx:239

• Draft comment:
  Consider simplifying the conditional check for CPU extensions by directly using hardwareData.cpu?.extensions?.length > 0 instead of joining the array and checking the string length.
• Reason this comment was not posted:
  Comment was on unchanged code.

2. web-app/src/routes/system-monitor.tsx:39

• Draft comment:
  The polling logic for getSystemUsage is duplicated here; consider refactoring this into a shared custom hook to reduce redundancy.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment claims there is duplication but I only see one polling implementation. Without seeing evidence of duplication elsewhere, this comment appears to be speculative or incorrect. Even if there is duplication somewhere else in the codebase, that would be a cross-file issue which we're instructed to ignore. I could be missing duplicate polling logic in other files. The reviewer may have broader context about similar patterns elsewhere in the codebase. Even if there is duplication elsewhere, we're explicitly told to ignore cross-file issues. Within this file alone, there is no evidence of duplication. The comment should be deleted as it claims there is code duplication without providing clear evidence within this file, and any potential duplication across files should be ignored per our instructions.

3. web-app/src/routes/system-monitor.tsx:97

• Draft comment:
  Ensure to guard against division by zero in the RAM usage calculation, as hardwareData.total_memory may be zero.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_PsERftlumnZV7NQR

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 37.58%

Your code coverage diff: -0.09% ▾

Uncovered files and lines

File	Lines
web-app/src/routes/system-monitor.tsx	2-13, 15-17, 19-21, 23-29, 31, 33, 35-36, 39-48, 50-51, 54-58, 61-66, 68-72, 75-77, 79-82, 84-94, 97-101, 103-110, 112, 114-151, 154-199, 202-217, 219-237, 239-241, 243-246, 248
web-app/src/routes/settings/hardware.tsx	1-19, 22-24, 26-35, 37-38, 41-48, 51-53, 56-76, 78, 81-86, 88-92, 95-97, 99-102, 104-114, 116-126, 128-129, 131-132, 134-136, 138, 140-142, 144-151, 154-156, 159-166, 168-175, 177-187, 189-190, 192, 194-200, 202-208, 210-211, 214-220, 222-228, 230-236, 238-246, 248, 250-263, 265, 267-268, 271-277, 279-287, 289-301, 303-305, 307-311, 313-314, 316, 318-319, 322-332, 334-341, 351-358, 360-369, 371-374, 376, 378, 380, 382-384, 386

[louis-jan]

LGTM