-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: bring back HF repo ID search in Hub #5880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27dc433 to
fcf5960
Compare
qnixsynapse
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 88ff20a in 1 minute and 59 seconds. Click for details.
- Reviewed
787lines of code in4files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/__tests__/useModelSources.test.ts:237
- Draft comment:
Good update: the tests now assert state changes for addSource using CatalogModel objects instead of relying on console.log. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/routes/hub/__tests__/huggingface-conversion.test.ts:4
- Draft comment:
Comprehensive tests for the conversion logic; consider extracting convertHfRepoToCatalogModel into a shared utility module to avoid duplicating the logic in the component. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. web-app/src/routes/hub/index.tsx:103
- Draft comment:
Using a case‐insensitive regex to remove the file extension is a solid improvement over a plain string replace. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. web-app/src/routes/hub/index.tsx:86
- Draft comment:
The conversion logic here is duplicated from the tests; consider extracting it to a shared helper to improve maintainability. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. web-app/src/routes/hub/index.tsx:139
- Draft comment:
Consider using a debouncing utility instead of manual setTimeouts for handling repo search updates, to simplify the logic. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. web-app/src/routes/hub/index.tsx:516
- Draft comment:
The global constant IS_LINUX is used for disabling the overlay. Ensure it is defined or imported to avoid runtime issues. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. web-app/src/services/__tests__/models.test.ts:277
- Draft comment:
FetchHuggingFaceRepo tests are thorough, covering various input formats and error scenarios. Nice job! - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_R4OMsjiYLLhfk9cK
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 36.91%Your code coverage diff: -0.04% ▾ Uncovered files and lines
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR is to add back missing function where users can input HF repository ID in Hub search box to download GGUF models.
This is a part of cortex deprecation where we don't add source to cortex for this action but just fetch directly the repo information.
CleanShot.2025-07-23.at.21.46.32.mp4
Fixes Issues
Self Checklist
Important
Reintroduces HF repository ID search in Hub for direct GGUF model downloads, updating
useModelSourcesand addingfetchHuggingFaceRepofunction with corresponding tests.Hubcomponent to fetch and display HF repository data.fetchHuggingFaceRepofunction inmodels.tsto retrieve HF repo data.useModelSourcesinuseModelSources.tsto handleCatalogModelinstead of strings.useModelSources.test.tsto reflect newaddSourcebehavior.huggingface-conversion.test.tsto test conversion of HF repo data toCatalogModel.models.test.tsto include tests forfetchHuggingFaceRepo.HuggingFaceRepointerface tomodels.tsfor type safety.index.tsxinroutes/hubto integrate HF repo search and display.This description was created by
for 88ff20a. You can customize this summary. It will automatically update as commits are pushed.