Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Jul 23, 2025

This pull request simplifies the artifact naming conventions across GitHub Actions workflows for Tauri builds. The changes standardize the artifact names by removing conditional logic and ensuring consistency across platforms.

Standardization of artifact naming:


Important

Standardizes artifact naming across Linux, macOS, and Windows builds by removing conditional logic and ensuring consistent naming conventions.

  • Artifact Naming Standardization:
    • In template-tauri-build-linux-x64.yml, removed conditional logic for artifact names, using jan-linux-amd64-${{ inputs.new_version }}-deb and jan-linux-amd64-${{ inputs.new_version }}-AppImage.
    • In template-tauri-build-macos.yml, included channel in artifact name as jan-${{ inputs.channel }}-mac-universal-${{ inputs.new_version }}.dmg.
    • In template-tauri-build-windows-x64.yml, simplified artifact naming to jan-windows-${{ inputs.new_version }}.

This description was created by Ellipsis for 31b3ee6. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Jul 23, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 31b3ee6 in 2 minutes and 15 seconds. Click for details.
  • Reviewed 47 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/template-tauri-build-linux-x64.yml:167
  • Draft comment:
    The Linux artifact names now use jan-linux-amd64-${{ inputs.new_version }}-deb and ...-AppImage without a dot before the file extension (previously ".deb" and ".AppImage"). This change removes the conventional extension separator – please confirm this is intentional and that downstream consumers aren’t affected.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The artifact names are only used internally during the build process. The final release artifacts use a different naming scheme entirely. The change in separator is unlikely to cause issues since these are just temporary build artifacts. The comment is asking for confirmation about something that doesn't seem to have meaningful impact. I could be wrong about the significance of artifact naming conventions in CI/CD pipelines. There might be downstream tools that expect specific formats. Even if there were downstream tools, they would interact with the final release artifacts which maintain their conventional naming, not these temporary build artifacts. This comment should be deleted as it's asking for confirmation about a change that has no significant impact, since these are just temporary build artifacts.
2. .github/workflows/template-tauri-build-macos.yml:192
  • Draft comment:
    Including the channel in the macOS artifact name (jan-${{ inputs.channel }}-mac-universal-${{ inputs.new_version }}.dmg) improves clarity. Make sure any downstream steps that reference this artifact name are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. .github/workflows/template-tauri-build-windows-x64.yml:198
  • Draft comment:
    The Windows artifact name is now set to jan-windows-${{ inputs.new_version }} and omits the .exe extension that was present before. Please verify this omission is intentional and that no downstream integration depends on the .exe suffix.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The artifact name is just a label for GitHub Actions storage. The actual .exe files are still preserved with their extensions in the path parameter. The artifact name doesn't need to match the file extension since it's just a container label. The change appears intentional to simplify naming. I could be wrong about whether downstream processes depend on the artifact name format. There could be scripts that expect the .exe extension in the artifact name. The actual file paths and names are preserved correctly with .exe extensions where it matters. The artifact name is an internal GitHub Actions label that shouldn't affect functionality. The comment should be deleted as it raises a non-issue. The .exe extension in the artifact name is unnecessary since the actual executable files maintain their extensions.

Workflow ID: wflow_ii1Enh2nkUBYFjvO

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@Minh141120 Minh141120 merged commit d8b6b10 into release/v0.6.6 Jul 23, 2025
25 of 27 checks passed
@Minh141120 Minh141120 deleted the chore/revert-app-artifact-name branch July 23, 2025 14:27
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 23, 2025
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants