-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ci: autoqa github artifact #5873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to a917bd8 in 1 minute and 24 seconds. Click for details.
- Reviewed
97lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/autoqa-template.yml:146
- Draft comment:
Consider using an explicit ternary operator (e.g.${{ inputs.is_nightly ? 'jan-nightly' : 'jan' }}) for artifact names instead of using&&/||for clarity. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. .github/workflows/autoqa-template.yml:130
- Draft comment:
The steps for collecting and uploading Jan logs (and recordings) are repeated across Windows, Ubuntu, and macOS jobs. Consider refactoring these into a reusable workflow or composite action to reduce duplication. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. .github/workflows/autoqa-template.yml:292
- Draft comment:
Ensure that the 'autoqa/recordings/' directory exists before attempting to upload artifacts to avoid potential upload failures. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_LhoHM1NxmOUMyoJo
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request enhances the
autoqa-template.ymlworkflow by adding steps to collect and upload logs and screen recordings as artifacts for better debugging and traceability. These changes ensure that logs from different environments (Windows, Linux, macOS) are gathered and uploaded consistently.Improvements to artifact collection and upload:
Log collection for all environments:
$env:APPDATA, Linux:~/.local/share, macOS:~/Library/Application Support) and save them to a common directory for artifact upload. [1] [2] [3]Artifact upload for screen recordings:
Artifact upload for logs:
Important
Enhances
autoqa-template.ymlto collect and upload logs and screen recordings as artifacts for Windows, Linux, and macOS environments.autoqa/jan-logsfor artifact upload.This description was created by
for a917bd8. You can customize this summary. It will automatically update as commits are pushed.