-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: app should not show manually deleted models #5868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
louis-jan
merged 1 commit into
release/v0.6.6
from
fix/app-should-refresh-local-model-list-onload
Jul 23, 2025
Merged
fix: app should not show manually deleted models #5868
louis-jan
merged 1 commit into
release/v0.6.6
from
fix/app-should-refresh-local-model-list-onload
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to a863241 in 1 minute and 40 seconds. Click for details.
- Reviewed
53lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. autoqa/tests/new-user/1-user-start-chatting.txt:3
- Draft comment:
Test instructions updated to use qwen3-0.6B. Ensure this matches the recommended model in the hub. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. web-app/src/hooks/useModelProvider.ts:75
- Draft comment:
Conditional assignment uses 'provider.persist ? provider?.models : mergedModels'. Verify that using cached models when persist is true does not reintroduce stale model data after manual deletion. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50% The comment raises a valid concern - when persist is true, we use provider.models directly which could include deleted models since it bypasses the filtering logic. This could lead to deleted models reappearing. However, the comment is phrased as a verification request rather than pointing out a clear issue. The underlying concern is real but the comment format violates our rules. The comment identifies a real potential bug, but it's phrased as a verification request which violates our rules. Maybe the issue isn't actually a bug but an intended behavior for persisted providers? While the phrasing isn't ideal, the underlying technical concern about bypassing deletion filtering is concrete and actionable - it's not speculative and points to a specific code path that could cause problems. The comment should be rewritten to directly state the issue rather than asking for verification, but the core concern about bypassing deletion filtering is valid and worth fixing.
3. web-app/src/routes/hub/index.tsx:39
- Draft comment:
Default model quantizations were changed to remove the '.gguf' extension. Confirm the matching logic in the download button aligns with this update. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. web-app/src/services/providers.ts:22
- Draft comment:
A TODO was added regarding checking chat_template for tool call support. Consider adding more context or addressing this soon. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_OaMI8s0LLtB0x2NH
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 36.93%Your code coverage diff: -0.01% ▾ Uncovered files and lines
|
urmauur
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where the app continued to show models that were manually deleted from the filesystem. Previously, the app used a cached models list, which became stale when users removed model files directly. Additionally, this PR enhances the model hub to show proper recommended models for download.
Changes
🔧 Model List Refresh
llama.cpp list()function to get current model state🚀 Model Hub Enhancement
Testing