fix: prevent terminal window from opening on model load on WindowsOS #5837
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, spawning the llamacpp server was causing an unwanted terminal window to appear. This is now fixed by combining `CREATE_NO_WINDOW` with `CREATE_NEW_PROCESS_GROUP` using `.creation_flags(...)`, ensuring that the process runs in the background without a console window. This change only applies to 64-bit Windows builds.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d30d819 in 1 minute and 13 seconds. Click for details.
- Reviewed
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/core/utils/extensions/inference_llamacpp_extension/server.rs:147
- Draft comment:
Good fix! Combining CREATE_NO_WINDOW with CREATE_NEW_PROCESS_GROUP effectively prevents the unwanted terminal window on Windows. As an optional improvement, consider using constants from a Windows-specific crate (e.g., windows-sys or winapi) for better clarity and maintainability. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_OBL04HXCdyvAVLh9
You can customize 
Barecheck - Code coverage reportTotal: 35%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, spawning the llamacpp server was causing an unwanted terminal window to appear. This is now fixed by combining
CREATE_NO_WINDOWwithCREATE_NEW_PROCESS_GROUPusing.creation_flags(...), ensuring that the process runs in the background without a console window.This change only applies to Windows builds.
Important
Prevents terminal window from opening on Windows when spawning llamacpp server by adjusting process creation flags in
load_llama_model().CREATE_NO_WINDOWwithCREATE_NEW_PROCESS_GROUPinload_llama_model().This description was created by
for d30d819. You can customize this summary. It will automatically update as commits are pushed.