-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Sync release/0.6.5 into dev to start new development cycle #5801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…click (#5712) * 🐛fix: default show 3 dots * ✨enhancement: enable resizable left panel (#5713) * ✨enhancement: enable resizable left panel * Update web-app/src/hooks/useLeftPanel.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Merge Release/v0.6.6 into release 0.6.5
feat: identidy jan for openrouter
…acpp feat: bump version of llama.cpp - b5857
…lation-mode fix: revert installationmode in nsis template
🐛fix: download icon when left panel close
…tom-endpoint-crashes-app fix: fetch models from custom provider causes app to crash
urmauur
approved these changes
Jul 17, 2025
qnixsynapse
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to c283979 in 2 minutes and 8 seconds. Click for details.
- Reviewed
720lines of code in25files - Skipped
0files when reviewing. - Skipped posting
14draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/tauri.bundle.windows.nsis.template:35
- Draft comment:
Change INSTALLMODE to "currentUser". Verify that switching from 'both' to 'currentUser' is intended for your user base; in multi-user environments additional adjustments might be required. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify their intention, which is against the rules. It suggests a change but then asks for verification, which is not allowed. The comment should be removed.
2. web-app/package.json:69
- Draft comment:
Token.js fork version updated from 0.7.12 to 0.7.15. Confirm that there are no breaking changes in the new version that affect functionality. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to confirm that there are no breaking changes in the new version of a dependency. This violates the rule against asking the author to confirm or ensure things, especially related to dependencies.
3. web-app/src/components/ui/resizable.tsx:1
- Draft comment:
The new resizable panel component appears well implemented. Ensure you test its behavior on various device sizes to confirm layout consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. web-app/src/containers/DownloadManegement.tsx:240
- Draft comment:
The download UI updates and toast messages seem clear; verify that overallProgress and downloadCount are computed correctly to reflect current download states. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify the correctness of the computation of overallProgress and downloadCount. This falls under asking the author to double-check things, which is against the rules. The comment does not provide a specific suggestion or point out a specific issue.
5. web-app/src/containers/LeftPanel.tsx:86
- Draft comment:
When using useClickOutside, the dependency array includes ref.current values. Consider using stable callback refs instead since .current is mutable and may not trigger re-renders as expected. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. web-app/src/containers/ThreadList.tsx:108
- Draft comment:
Good use of onContextMenu to open the dropdown. Ensure that this doesn't interfere with any native context menu behaviors needed elsewhere in the app. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
7. web-app/src/containers/dialogs/ToolApproval.tsx:52
- Draft comment:
Transitioning from using for rich text translations to concatenating the translated string with a for the tool name simplifies the markup; ensure that translation keys reflect this new format. - Reason this comment was not posted:
Comment looked like it was already resolved.
8. web-app/src/hooks/useModelProvider.ts:39
- Draft comment:
The merging and filtering logic for existing provider models is robust. Double-check edge cases when model IDs might be absent or non-string to avoid silent failures. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to double-check edge cases, which violates the rule against asking the author to confirm or ensure behavior. It doesn't provide a specific suggestion or point out a specific issue in the code.
9. web-app/src/lib/completion.ts:151
- Draft comment:
Avoid using the 'in' operator on an array to check for a value. Replace '!(thread.model.id in Object.values(models).flat())' with an 'Array.includes()' check. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. web-app/src/lib/completion.ts:141
- Draft comment:
Good implementation of conditional headers for openrouter. Ensure that the keys 'HTTP-Referer' and 'X-Title' are accepted by the API, as these might differ across providers. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is informative and suggests ensuring that certain keys are accepted by the API. However, it does not provide a specific code suggestion or ask for a specific test to be written. It also asks the author to ensure something, which is against the rules.
11. web-app/src/routes/__root.tsx:74
- Draft comment:
The new AppLayout using ResizablePanelGroup is well structured. Test extensively across screen sizes to ensure the handlePanelLayout callback correctly updates panel size and visibility. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and suggests testing extensively, which violates the rules. It doesn't provide a specific code suggestion or ask for a specific test to be written.
12. web-app/src/routes/settings/general.tsx:92
- Draft comment:
Using Tauri's WebviewWindow for logs is a good approach. Ensure proper error handling is in place if creating or focusing the logs window fails. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. web-app/src/routes/settings/providers/index.tsx:41
- Draft comment:
Lowercase comparison when checking for duplicate provider names is a good safeguard. Verify that this approach covers all edge cases for provider naming. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify that the approach covers all edge cases, which violates the rule against asking the author to confirm or ensure behavior. It does not provide a specific suggestion or point out a specific issue with the code.
14. web-app/src/services/providers.ts:211
- Draft comment:
Consider adding more robust type checks for different response formats from the provider API. The current handling works for known formats, but unexpected formats should be logged and handled gracefully. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_vm59FMnSjR8iUezP
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Syncing the release/0.6.5 branch into dev to incorporate all release changes and prepare for the next development cycle.
Changes
Purpose
This sync ensures that:
Notes
Important
Merge
release/0.6.5intodev, updating version numbers, configurations, and dependencies, and adding new UI components and localization updates.release/0.6.5intodevbranch.CORTEX_ENGINE_VERSIONtob5857inrolldown.config.mjs,download.bat, anddownload.sh.react-resizable-panelsdependency inpackage.json.ResizablePanelGroup,ResizablePanel, andResizableHandlecomponents inresizable.tsx.DownloadManagement.tsxto handle download progress and errors.LeftPanel.tsxfor responsive design and resizable context.common.json,tools.json, and other locale files.README.md.app.py.This description was created by
for c283979. You can customize this summary. It will automatically update as commits are pushed.