Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 17, 2025

This pull request removes the deprecated e2e testing framework based on Selenium and Tauri.

  1. Updating the codebase and test cases will require engineering efforts.
  2. This approach doesn't cover all platforms or extensive hardware testing.
  3. Microsoft has deprecated certain web driver binaries.

See more in #5639

Removal of E2E Testing Framework:

  • Makefile: Replaced the yarn test:e2e command with cargo test to use Rust's testing framework instead of the previous JavaScript-based E2E tests.
  • tests-e2e-js workspace: Removed the entire tests-e2e-js workspace, including its package.json, src/main.ts, .gitignore, and tsconfig.json files, as well as all dependencies and scripts related to Selenium and Tauri. [1] [2] [3] [4]

Important

Remove deprecated Selenium and Tauri-based E2E testing framework, replacing it with Rust's testing framework.

  • Testing Framework Removal:
    • Removed Selenium and Tauri-based E2E testing framework.
    • Replaced yarn test:e2e with cargo test in Makefile.
    • Deleted tests-e2e-js workspace, including package.json, src/main.ts, .gitignore, and tsconfig.json.
  • Scripts and Commands:
    • Removed test:e2e related scripts from package.json.
    • Updated Makefile to use Rust's testing framework instead of JavaScript-based tests.

This description was created by Ellipsis for 3102a59. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b8edce9 in 51 seconds. Click for details.
  • Reviewed 130 lines of code in 5 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:46
  • Draft comment:
    Ensure that replacing 'yarn test:e2e' with 'cargo test --manifest-path src-tauri/Cargo.toml' fully covers the previous E2E functionality. Confirm that the new Rust tests validate the same scenarios.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. package.json:6
  • Draft comment:
    Removal of the 'tests-e2e-js' workspace and related E2E scripts is complete. Verify that no residual references or dependencies on the deprecated testing framework remain.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_Ffk630vaVQ8olDrQ

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

Barecheck - Code coverage report

Total: 35.34%

Your code coverage diff: 0.07% ▴

✅ All code changes are covered

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 4498828 in 57 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:46
  • Draft comment:
    Add a brief comment explaining why 'yarn copy:assets:tauri' is executed before cargo tests to clarify its purpose.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_ErswA2oDWMFTpsnI

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed cef7b10 in 1 minute and 23 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:46
  • Draft comment:
    Confirm that adding 'yarn build:icon' in the test target is intentional. If icon assets are needed before tests or for production assets, consider adjusting the order or moving this step to a dedicated build phase.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates several rules. It asks for confirmation of intention ("Confirm that...") which is explicitly forbidden. It's speculative ("If icon assets are needed..."). Without deeper context about the build system and test requirements, we can't know if this placement is incorrect. The author likely had a reason for adding it here. Maybe the icon build step is actually misplaced and could cause issues during testing or CI/CD pipelines? Even if the placement could be improved, asking for confirmation and making speculative suggestions isn't helpful. If there's a concrete issue, it should be stated directly. Delete this comment as it violates rules against asking for confirmation and making speculative suggestions.

Workflow ID: wflow_NU6AkT00VGX8PQfu

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed 3102a59 in 1 minute and 31 seconds. Click for details.
  • Reviewed 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_M42ovn3KrdXVMWzC

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan louis-jan merged commit 4699b07 into release/v0.7.0 Jul 17, 2025
11 checks passed
@louis-jan louis-jan deleted the test/deprecate-webdriver-test branch July 17, 2025 14:28
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 17, 2025
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants