-
Notifications
You must be signed in to change notification settings - Fork 2.3k
test: deprecate webdriver test in favor of auto qa using CUA #5797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to b8edce9 in 51 seconds. Click for details.
- Reviewed
130lines of code in5files - Skipped
1files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:46
- Draft comment:
Ensure that replacing 'yarn test:e2e' with 'cargo test --manifest-path src-tauri/Cargo.toml' fully covers the previous E2E functionality. Confirm that the new Rust tests validate the same scenarios. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. package.json:6
- Draft comment:
Removal of the 'tests-e2e-js' workspace and related E2E scripts is complete. Verify that no residual references or dependencies on the deprecated testing framework remain. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_Ffk630vaVQ8olDrQ
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 35.34%Your code coverage diff: 0.07% ▴ ✅ All code changes are covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 4498828 in 57 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:46
- Draft comment:
Add a brief comment explaining why 'yarn copy:assets:tauri' is executed before cargo tests to clarify its purpose. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_ErswA2oDWMFTpsnI
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed cef7b10 in 1 minute and 23 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:46
- Draft comment:
Confirm that adding 'yarn build:icon' in the test target is intentional. If icon assets are needed before tests or for production assets, consider adjusting the order or moving this step to a dedicated build phase. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates several rules. It asks for confirmation of intention ("Confirm that...") which is explicitly forbidden. It's speculative ("If icon assets are needed..."). Without deeper context about the build system and test requirements, we can't know if this placement is incorrect. The author likely had a reason for adding it here. Maybe the icon build step is actually misplaced and could cause issues during testing or CI/CD pipelines? Even if the placement could be improved, asking for confirmation and making speculative suggestions isn't helpful. If there's a concrete issue, it should be stated directly. Delete this comment as it violates rules against asking for confirmation and making speculative suggestions.
Workflow ID: wflow_NU6AkT00VGX8PQfu
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed 3102a59 in 1 minute and 31 seconds. Click for details.
- Reviewed
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_M42ovn3KrdXVMWzC
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This pull request removes the deprecated e2e testing framework based on Selenium and Tauri.
See more in #5639
Removal of E2E Testing Framework:
yarn test:e2ecommand withcargo testto use Rust's testing framework instead of the previous JavaScript-based E2E tests.tests-e2e-jsworkspace: Removed the entiretests-e2e-jsworkspace, including itspackage.json,src/main.ts,.gitignore, andtsconfig.jsonfiles, as well as all dependencies and scripts related to Selenium and Tauri. [1] [2] [3] [4]Important
Remove deprecated Selenium and Tauri-based E2E testing framework, replacing it with Rust's testing framework.
yarn test:e2ewithcargo testinMakefile.tests-e2e-jsworkspace, includingpackage.json,src/main.ts,.gitignore, andtsconfig.json.test:e2erelated scripts frompackage.json.Makefileto use Rust's testing framework instead of JavaScript-based tests.This description was created by
for 3102a59. You can customize this summary. It will automatically update as commits are pushed.