Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Jul 15, 2025

Describe Your Changes

This pull request makes small adjustments to the SortableItem component in web-app/src/containers/ThreadList.tsx to improve styling and interactivity for thread items. The changes include adding a new CSS class and modifying hover behavior.

Styling improvements:

  • Updated the className property for the container element to include a new group/thread-list class, enhancing hover functionality and grouping behavior.
  • Modified the className property for the IconDots element to adjust its size dynamically based on hover and state conditions, improving visual feedback for user interactions.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Fix hover behavior for three dots icon in ThreadList.tsx by updating CSS class for IconDots.

  • UI Fix:
    • In ThreadList.tsx, added group-hover/thread-list:data-[state=closed]:size-5 to IconDots class to revert hover behavior for three dots icon.
    • Ensures the icon size changes on hover when the dropdown is closed.

This description was created by Ellipsis for ab0be3b. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.5 milestone Jul 15, 2025
@urmauur urmauur requested a review from louis-jan July 15, 2025 02:56
@urmauur urmauur self-assigned this Jul 15, 2025
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@urmauur urmauur moved this to Needs Review in Jan Jul 15, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to ab0be3b in 1 minute and 2 seconds. Click for details.
  • Reviewed 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/ThreadList.tsx:113
  • Draft comment:
    Added the 'group/thread-list' class to the container. Ensure this group identifier aligns with your Tailwind configuration and doesn't conflict with other group naming conventions.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. web-app/src/containers/ThreadList.tsx:130
  • Draft comment:
    The IconDots now uses conditional size utilities ('group-hover/thread-list:data-[state=closed]:size-5' and 'data-[state=closed]:size-0'). Verify that these custom Tailwind variants yield the intended effect (hiding the icon in 'closed' state unless the parent is hovered).
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_8zBoNpe2F4PS2Vtq

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@urmauur urmauur merged commit 02c0496 into release/v0.6.5 Jul 15, 2025
11 checks passed
@urmauur urmauur deleted the fix/three-dots branch July 15, 2025 03:34
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants