Skip to content

Conversation

@bytrangle
Copy link
Contributor

@bytrangle bytrangle commented Jul 14, 2025

Describe Your Changes

I added an instruction that tells users to toggle experimental features first. t. Without it, the MCP Servers tab won't appear.

Fixes Issues

N/A

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Adds instruction in mcp.mdx to enable experimental features before toggling MCP Servers for tab visibility.

  • Documentation Update:
    • In mcp.mdx, added instruction to enable experimental features at General > Advanced before accessing Settings > MCP Servers.
    • Ensures MCP Servers tab visibility for users following setup instructions.

This description was created by Ellipsis for b7a7557. You can customize this summary. It will automatically update as commits are pushed.

The original instruction doesn't tell users to enable experimental features in Jan first. Without it, the MCP Servers tab won't appear.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b7a7557 in 36 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/pages/docs/mcp.mdx:127
  • Draft comment:
    Good clarification: the added instruction to enable experimental features first improves user guidance. Ensure that the UI labels ('General > Advanced' and 'Settings > MCP Servers') match the actual app UI and consider adding a brief note (if space permits) on why this order is required.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_rz2eN87iYvDODnRk

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan louis-jan requested a review from ramonpzg July 15, 2025 15:47
@louis-jan
Copy link
Contributor

This is a great catch. Thank you! cc @ramonpzg

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit 04f8bf0 into janhq:dev Jul 20, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

2 participants