-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Install Posthog snippet #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hantran-co
commented
Nov 9, 2023
- Install Posthog snippet
- Will create events/actions once Faisal completes Jan's new web design
|
@urmauur
|
louis-jan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've also experienced this issue, but it doesn't seem to affect building on Prod |
|
@dan-jan we move to env, will DM you regarding |
|
@imtuyethan @hiento09 I encountered this issue when running
I saw the GTM_ID specified in .env.example, but we should either provide a dev env GTM_ID, or it'll be quite tough for contributors if they have to specify their own. |
I think my concern is with contributors who might want to git clone Docs and add to it. We should not require them to have a Is it still best practice in 2023 to check for |
|
@hiento09 @louis-jan @imtuyethan @urmauur Btw, for Docs, I actually would recommend having hard-coded Posthog and GTM IDs.
Hard-coding Analytics IDs ironically helps us find out when lazy forkers just deploy a docs site. I don't intend to prevent that, but it would be nice to be able to track that from our analytics. We can then see traffic stats by domain (including localhost, as a measure of dev documentation activity). |
|
Hi @dan-jan not sure if we hardcode the GTM-ID, when someone fork the Jan docs and deploy to their web example, what happen if they still using our GTM-ID, but if we worried someone to contribute to Jan docs, i think we can add default something like this
so even someone missing cc @louis-jan |
|
Sounds good! My first objective is to make sure someone can contribute, without a |



