Skip to content

Inference Plugin pull nitro binary from release #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Inference Plugin pull nitro binary from release #524

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d347654
refactor nitro folder structure inside inference plugin
hiento09 Nov 1, 2023
a56db84
Change to flat folder structure for nitro binary
hiento09 Nov 1, 2023
af7290e
Remove all exiting nitro binary file
hiento09 Nov 1, 2023
c57e955
add download command for nitron linux cuda
hiento09 Nov 1, 2023
d95452a
Add yarn script to download nitro
jan-service-account Nov 1, 2023
a90ecf0
Add build deps to data-plugins yarn script
jan-service-account Nov 1, 2023
f3e7960
add chmod for nitro binary file
jan-service-account Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ package-lock.json
*.log
plugin-core/lib
core/lib/**

# Nitro binary files
plugins/inference-plugin/nitro/*/nitro
plugins/inference-plugin/nitro/*/*.exe
plugins/inference-plugin/nitro/*/*.dll
plugins/inference-plugin/nitro/*/*.metal
11 changes: 8 additions & 3 deletions plugins/inference-plugin/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,19 @@ const initModel = (fileName) => {

if (process.platform === "win32") {
// Todo: Need to check for CUDA support to switch between CUDA and non-CUDA binaries
binaryName = "nitro_start_windows.bat";
binaryName = "win-start.bat";
} else if (process.platform === "darwin") {
// Mac OS platform
binaryName = process.arch === "arm64" ? "nitro_mac_arm64" : "nitro_mac_intel";
if (process.arch === "arm64") {
binaryFolder = path.join(binaryFolder, "mac-arm64")
} else {
binaryFolder = path.join(binaryFolder, "mac-x64")
}
binaryName = "nitro"
} else {
// Linux
// Todo: Need to check for CUDA support to switch between CUDA and non-CUDA binaries
binaryName = "nitro_start_linux.sh"; // For other platforms
binaryName = "linux-start.sh"; // For other platforms
}

const binaryPath = path.join(binaryFolder, binaryName);
Expand Down
Loading