fix: model setting issues

Author: louis-jan

web-app/src/containers/ModelSetting.tsx

@@ -11,8 +11,7 @@ import {
 } from '@/components/ui/sheet'
 import { DynamicControllerSetting } from '@/containers/dynamicControllerSetting'
 import { useModelProvider } from '@/hooks/useModelProvider'
-import { updateModel, stopModel } from '@/services/models'
-import { ModelSettingParams } from '@janhq/core'
+import { stopModel } from '@/services/models'
 import { cn } from '@/lib/utils'
 import { useTranslation } from '@/i18n/react-i18next-compat'
 
@@ -71,22 +70,6 @@ export function ModelSetting({
         models: updatedModels,
       })
 
-      const params = Object.entries(updatedModel.settings).reduce(
-        (acc, [key, value]) => {
-          const rawVal = value.controller_props?.value
-          const num = parseFloat(rawVal as string)
-          acc[key] = !isNaN(num) ? num : rawVal
-          return acc
-        },
-        {} as Record<string, unknown>
-      ) as ModelSettingParams
-
-      updateModel({
-        id: model.id,
-        settings: params,
-        ...(params as unknown as object),
-      })
-
       // Call debounced stopModel only when updating ctx_len or ngl
       if (key === 'ctx_len' || key === 'ngl') {
         debouncedStopModel(model.id)

web-app/src/hooks/useModelProvider.ts

@@ -74,9 +74,17 @@ export const useModelProvider = create<ModelProviderState>()(
               ),
               ...models,
             ]
+            const updatedModels = provider.models?.map((model) => {
+              return {
+                ...model,
+                settings:
+                  models.find((m) => m.id === model.id)?.settings ||
+                  model.settings,
+              }
+            })
             return {
               ...provider,
-              models: provider.persist ? provider?.models : mergedModels,
+              models: provider.persist ? updatedModels : mergedModels,
               settings: provider.settings.map((setting) => {
                 const existingSetting = provider.persist
                   ? undefined

web-app/src/locales/en/common.json

@@ -119,6 +119,7 @@
   "createAssistant": "Create Assistant",
   "enterApiKey": "Enter API Key",
   "scrollToBottom": "Scroll to bottom",
+  "generateAiResponse": "Generate AI Response",
   "addModel": {
     "title": "Add Model",
     "modelId": "Model ID",

web-app/src/routes/threads/$threadId.tsx

@@ -325,7 +325,7 @@ function ThreadDetail() {
                 className="bg-main-view-fg/10 px-4 border border-main-view-fg/5 flex items-center justify-center rounded-xl gap-x-2 cursor-pointer pointer-events-auto"
                 onClick={generateAIResponse}
               >
-                <p className="text-xs">{t('Generate AI Response')}</p>
+                <p className="text-xs">{t('common:generateAiResponse')}</p>
                 <Play size={12} />
               </div>
             )}