Skip to content

Commit 5dd42dd

Browse files
committed
fix: update ux recemmend backend label into desc setting
1 parent 469d787 commit 5dd42dd

File tree

3 files changed

+38
-42
lines changed

3 files changed

+38
-42
lines changed

web-app/src/containers/dynamicControllerSetting/DropdownControl.tsx

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,6 @@ import {
55
DropdownMenuTrigger,
66
} from '@/components/ui/dropdown-menu'
77

8-
import {
9-
Tooltip,
10-
TooltipTrigger,
11-
TooltipContent,
12-
} from '@/components/ui/tooltip'
13-
import { IconStarFilled } from '@tabler/icons-react'
148
import { cn } from '@/lib/utils'
159

1610
// Dropdown component
@@ -24,7 +18,6 @@ type DropdownControlProps = {
2418
export function DropdownControl({
2519
value,
2620
options = [],
27-
recommended,
2821
onChange,
2922
}: DropdownControlProps) {
3023
const isSelected =
@@ -48,18 +41,6 @@ export function DropdownControl({
4841
)}
4942
>
5043
<span>{option.name}</span>
51-
{recommended === option.value && (
52-
<Tooltip>
53-
<TooltipTrigger asChild>
54-
<div className="cursor-pointer">
55-
<IconStarFilled className="text-accent" />
56-
</div>
57-
</TooltipTrigger>
58-
<TooltipContent side="top" sideOffset={8} className="z-50">
59-
Recommended
60-
</TooltipContent>
61-
</Tooltip>
62-
)}
6344
</DropdownMenuItem>
6445
))}
6546
</DropdownMenuContent>

web-app/src/routes/settings/providers/$providerName.tsx

Lines changed: 37 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -384,29 +384,43 @@ function ProviderDetail() {
384384
: false
385385
}
386386
description={
387-
<RenderMarkdown
388-
className="![>p]:text-main-view-fg/70 select-none"
389-
content={setting.description}
390-
components={{
391-
// Make links open in a new tab
392-
a: ({ ...props }) => {
393-
return (
394-
<a
395-
{...props}
396-
target="_blank"
397-
rel="noopener noreferrer"
398-
className={cn(
399-
setting.key === 'api-key' &&
400-
'second-step-setup-remote-provider'
401-
)}
402-
/>
403-
)
404-
},
405-
p: ({ ...props }) => (
406-
<p {...props} className="!mb-0" />
407-
),
408-
}}
409-
/>
387+
<>
388+
<RenderMarkdown
389+
className="![>p]:text-main-view-fg/70 select-none"
390+
content={setting.description}
391+
components={{
392+
// Make links open in a new tab
393+
a: ({ ...props }) => {
394+
return (
395+
<a
396+
{...props}
397+
target="_blank"
398+
rel="noopener noreferrer"
399+
className={cn(
400+
setting.key === 'api-key' &&
401+
'second-step-setup-remote-provider'
402+
)}
403+
/>
404+
)
405+
},
406+
p: ({ ...props }) => (
407+
<p {...props} className="!mb-0" />
408+
),
409+
}}
410+
/>
411+
{setting.key === 'version_backend' &&
412+
setting.controller_props?.recommended && (
413+
<div className="mt-1 text-sm text-main-view-fg/60">
414+
<span className="font-medium">
415+
{setting.controller_props.recommended
416+
?.split('/')
417+
.pop() ||
418+
setting.controller_props.recommended}
419+
</span>
420+
<span> is the recommended backend.</span>
421+
</div>
422+
)}
423+
</>
410424
}
411425
actions={actionComponent}
412426
/>

web-app/src/types/modelProviders.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ type ControllerProps = {
77
type?: string
88
options?: Array<{ value: number | string; name: string }>
99
input_actions?: string[]
10+
recommended?: string
1011
}
1112

1213
/**

0 commit comments

Comments
 (0)