bugfix: change file-naming scheme to account for multi-dir-deep dune libraries #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielf212
force-pushed
the
bugfix/include-subdirs-qualified
branch
from
e196db3 to
6090a3b
Compare
…libraries This also allows you to use the library for `(include_subdirs qualified)`. Signed-off-by: Ariel Fridman <[email protected]>
arielf212
force-pushed
the
bugfix/include-subdirs-qualified
branch
from
6090a3b to
7ab8f84
Compare
github-iron
added
the
forwarded-to-js-devs
|
Hi, thanks for posting this PR. I tried pulling your change in internally, but when I do so, the test suite fails. I think it's not enough to uniformly drop only the first directory --- we probably need to look at the value of the Ordinarily we'd be happy to help you make a contribution fixing your issue, but getting the test suite for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows you to use the library for
(include_subdirs qualified), which is perhaps the important contribution here :).This closes #61.
I am very new to ocaml but got bitten by this in my learning project, so decided to fix it.
I tried to follow the style of the repo, if there are any style or implementation problems I'll fix them.