Build hotRod image similar to all-in-one #5745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manoram Sharma <[email protected]>
yurishkuro
reviewed
Jul 16, 2024
Signed-off-by: Manoramsharma <[email protected]>
Member
|
please rebase |
yurishkuro
reviewed
Jul 18, 2024
| run_integration_test() { | ||
| local image_name="$1" | ||
| export CID | ||
| CID=$(docker run -d --name "${BINARY}" -p 8080:8080 "${image_name}:${GITHUB_SHA}") |
Member
There was a problem hiding this comment.
you have a bad merge, this is not how we run integration tests how.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test