Use docker compose for elasticsearch/opensearch integration tests#5490
Merged
Conversation
Signed-off-by: Your Name <you@example.com>
yurishkuro
reviewed
May 26, 2024
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
please make sure you're on the latest main, you are working against a stale version
Signed-off-by: Your Name <you@example.com>
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
yurishkuro
reviewed
May 27, 2024
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
Script change Lgtm overall
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
yurishkuro
reviewed
May 27, 2024
Member
|
did you do a local run of these tests? |
Contributor
Author
|
yes locally it is running fine |
yurishkuro
added
the
changelog:ci
Signed-off-by: Your Name <you@example.com>
yurishkuro
reviewed
May 27, 2024
yurishkuro
reviewed
May 27, 2024
yurishkuro
reviewed
May 27, 2024
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
yurishkuro
reviewed
May 28, 2024
added 2 commits
May 28, 2024 23:59
Signed-off-by: Your Name <you@example.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5490 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 330 330
Lines 16151 16151
=======================================
Hits 15538 15538
Misses 437 437
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
May 28, 2024
yurishkuro
reviewed
May 28, 2024
yurishkuro
reviewed
May 28, 2024
hellspawn679
changed the title
yurishkuro
reviewed
May 28, 2024
added 2 commits
May 29, 2024 03:55
yurishkuro
changed the title
Contributor
Author
|
@yurishkuro do you why is this codecov test failing |
Member
|
Thanks! |
3 tasks
Member
|
@hellspawn679 one thing we forgot is to add the sections to .github/dependabot.yml so that dependabot can actually upgrade versions in those files |
Member
|
codecov - I think it was just a delay, it now updated the comment saying 96% coverage #5490 (comment) |
Contributor
Author
|
ok i will add it
|
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this pull request
Jun 2, 2024
…egertracing#5490) ## Which problem is this PR solving? Part of jaegertracing#5485 ## Description of the changes * updated `script/es-integration-test.sh` to use docker compose files * updated `.github/workflows/ci-elasticsearch.yml` now it only passes the major version for elasticsearch * updated `.github/workflows/ci-opensearch.yml` now it only passes major version for opensearch * added docker compose files at `docker-compose/elasticsearch` and `docker-compose/opensearch` * removed` setup_es` and `setup_opensearch` function and a generalized `setup_db()` function ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Your Name <you@example.com> Signed-off-by: mehul gautam <mehulsharma4786@gmail.com> Co-authored-by: Your Name <you@example.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Part of #5485
Description of the changes
script/es-integration-test.shto use docker compose files.github/workflows/ci-elasticsearch.ymlnow it only passes the major version for elasticsearch.github/workflows/ci-opensearch.ymlnow it only passes major version for opensearchdocker-compose/elasticsearchanddocker-compose/opensearchsetup_esandsetup_opensearchfunction and a generalizedsetup_db()functionHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test