diff --git a/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/__snapshots__/index.test.js.snap b/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/__snapshots__/index.test.js.snap index 72150326c8..6270006775 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/__snapshots__/index.test.js.snap +++ b/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/__snapshots__/index.test.js.snap @@ -155,9 +155,7 @@ exports[` omits the operation if it is null 1`] = ` - + omits the operation if it is null 2`] = ` - + renders correctly when decorationValue is a string 1`] - + renders correctly when decorationValue is a string 2`] - + renders correctly when given decorationProgressbar 1`] - + renders correctly when given decorationProgressbar 2`] - + renders correctly when isFocalNode = true and focalNod - + renders correctly when isFocalNode = true and focalNod - + renders the number of operations if there are multiple - + renders the number of operations if there are multiple - + render renders detailLink 1`] = ` rel="noreferrer noopener" target="_blank" > - + diff --git a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/MetricCard.test.js.snap b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/MetricCard.test.js.snap index b74afc719a..bfdf286020 100644 --- a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/MetricCard.test.js.snap +++ b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/MetricCard.test.js.snap @@ -32,9 +32,7 @@ exports[`MetricCard renders as expected when passCount is zero 1`] = ` rel="noreferrer noopener" target="_blank" > - + @@ -109,9 +107,7 @@ exports[`MetricCard renders as expected with details 1`] = ` rel="noreferrer noopener" target="_blank" > - + @@ -228,9 +224,7 @@ exports[`MetricCard renders as expected without details 1`] = ` rel="noreferrer noopener" target="_blank" > - + @@ -305,9 +299,7 @@ exports[`MetricCard renders as expected without details 2`] = ` rel="noreferrer noopener" target="_blank" > - + diff --git a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/ScoreCard.test.js.snap b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/ScoreCard.test.js.snap index 448f6364b9..48c5535765 100644 --- a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/ScoreCard.test.js.snap +++ b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/ScoreCard.test.js.snap @@ -25,9 +25,7 @@ exports[`ScoreCard renders as expected when score is below max 1`] = ` target="_blank" > How to improve - + `; @@ -57,9 +55,7 @@ exports[`ScoreCard renders as expected when score is max 1`] = ` target="_blank" > Great! What does this mean - + `; @@ -90,9 +86,7 @@ exports[`ScoreCard renders as expected when score is zero 1`] = ` target="_blank" > How to improve - + `; diff --git a/packages/jaeger-ui/src/components/common/ErrorMessage.tsx b/packages/jaeger-ui/src/components/common/ErrorMessage.tsx index cfa7d1dd81..8885b1c9fd 100644 --- a/packages/jaeger-ui/src/components/common/ErrorMessage.tsx +++ b/packages/jaeger-ui/src/components/common/ErrorMessage.tsx @@ -48,8 +48,7 @@ function ErrorAttr({ name, value }: ErrorAttrProps) { ); } -export function Message(props: SubPartProps) { - const { className, error, wrap, wrapperClassName } = props; +export function Message({ className, error, wrap = false, wrapperClassName }: SubPartProps) { const cssClass = `ErrorMessage--msg ${className || ''}`; const msg = @@ -66,15 +65,7 @@ export function Message(props: SubPartProps) { return msg; } -Message.defaultProps = { - className: undefined, - wrap: false, - wrapperClassName: undefined, -}; - -export function Details(props: SubPartProps) { - const { className, error, wrap, wrapperClassName } = props; - +export function Details({ className, error, wrap = false, wrapperClassName }: SubPartProps) { if (typeof error === 'string') { return null; } @@ -113,12 +104,6 @@ export function Details(props: SubPartProps) { return details; } -Details.defaultProps = { - className: undefined, - wrap: false, - wrapperClassName: undefined, -}; - export default function ErrorMessage({ className, detailClassName, @@ -140,9 +125,3 @@ export default function ErrorMessage({ ); } - -ErrorMessage.defaultProps = { - className: undefined, - detailClassName: undefined, - messageClassName: undefined, -}; diff --git a/packages/jaeger-ui/src/components/common/NewWindowIcon.tsx b/packages/jaeger-ui/src/components/common/NewWindowIcon.tsx index bbe48f2c7f..4a5dd7037a 100644 --- a/packages/jaeger-ui/src/components/common/NewWindowIcon.tsx +++ b/packages/jaeger-ui/src/components/common/NewWindowIcon.tsx @@ -22,12 +22,7 @@ type Props = { isLarge?: boolean; }; -export default function NewWindowIcon(props: Props) { - const { isLarge, ...rest } = props; +export default function NewWindowIcon({ isLarge = false, ...rest }: Props) { const cls = cx('NewWindowIcon', { 'is-large': isLarge }); return ; } - -NewWindowIcon.defaultProps = { - isLarge: false, -};