[LoadingIndicator]: Replace defaultProps with destructuring

[its-me-abhishek]

Which problem is this PR solving?

• Part of [Bug]: Support for defaultProps in Function Components to be Removed #2596

Description of the changes

• Updated the LoadingIndicator component to remove defaultProps so as to avoid the deprecation warnings.
• Updated the snapshots so as to match the new LoadingIndicator.

How was this change tested?

• Running npm ci npm run update-snapshots and npm test passes all the tests
• Tested manually by rendering LoadingIndicator using various props

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: npm run lint and npm run test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (7104ef3) to head (8d44145).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2601   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         255      255           
  Lines        7745     7745           
  Branches     1999     1988   -11     
=======================================
  Hits         7483     7483           
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

make sure npm run lint is successful on your machine

[its-me-abhishek]

this linting issue (similar but not the same)

Type '{ className: string; }' is missing the following properties from type '{ centered: boolean; vcentered?: boolean | undefined; className: string; small: boolean; style?: CSSProperties | undefined; }': centered, smallts(2739)

is there in all the components, either i will have to explicitly mention all the non optional props that are not passed yet, from all the components that use loading indicator, or make these optional in the loading indicator itself.
what shall i proceed with?

[yurishkuro]

maybe make centered, small optional again?

[its-me-abhishek]

Done, the lint tests pass now

[yurishkuro]

Thanks!