-
Notifications
You must be signed in to change notification settings - Fork 586
[ci]: Add workflow to guard against growing bundle size #2586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hariom Gupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 255 255
Lines 7732 7732
Branches 2009 1996 -13
=======================================
Hits 7468 7468
Misses 264 264 ☔ View full report in Codecov by Sentry. |
|
Just noticed, we already do a build in Lint and Build workflow. Should I include the bundle_check part in that workflow instead of creating a separate one? |
|
I think it's good to have this one separate, because if it fails we can occasionally override it and still merge (when we deem the size change legitimate), we probably won't make this check required. |
|
It doesn't look like your new workflow ran, perhaps a syntax error |
I would try fixing as per the comments though |
Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
|
Looks like some issue. How is it getting a cache hit? We haven't yet pushed to main branch after merging this PR |
Signed-off-by: Hariom Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Signed-off-by: Hariom Gupta <[email protected]>
|
There was an issue (cache was getting saved in the PRs) which I just fixed in the latest commit. Actually |
Which problem is this PR solving?
Description of the changes
This GH Workflow would go through the following steps:
builddirectory generated when we runnpm run buildnew_bundle_size.txtfilebundle_size.txtfile from cache, if present.bundle_size.txt(contains old size) with thenew_bundle_size.txt(contains new size).bundle_size.txtto cacheHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test