Fix NPE and reduce nesting #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I didn't notice the issue when testing, but perhaps it was because I had cleaned and only opened the relevant projects, ie "Happy flow" |
Contributor
Author
|
It doesn't look the error actually causes any ill effect. It is just present on the logs. Noticed randomly while testing the Maven version thing. That is why I also was unsure if all the rest of the code block there can be skipped if the project is not a Gradle project... |
Contributor
Author
|
Ok, I checked the history, so yeah, now the NPE is gone an otherwise everything is as before for other than Gradle types. I think it is correct now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the Ant projects should just continue to the few lines after the seemingly Gradle specific thing... But Ant project assets seem to work ok (shows the yellow icon and can open to scene explorer). Having Ant projects open, this resulted in nasty NPE.