Skip to content

Commit da770aa

Browse files
committed
Minor spelling/explaining and formatting fixes
1 parent dfe6cbb commit da770aa

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

harness-override/README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
## What does this folder do?
22
This is pretty simple:
33
Since our SDK is based on Netbeans we download the so-called Netbeans Harness from official sources.
4-
This Harness is basicaly the Skeleton of our SDK.
4+
This Harness is basically the skeleton of our SDK.
55

6-
In order to change the Icon on Windows Systems we need to change files of said Harness.
6+
In order to change the icon on Windows Systems we need to change files of said Harness.
77
Since this harness could be re-downloaded any time we needed the `overrideHarness` build functionality.
8+
It simply overwrites harness files _each build_ (When necessary).
89

9-
It overwrites harness files *each build* (When necessary).
10-
In this folder are our patched .exe files which will replace the harness files.
10+
In this folder you'll find our patched .exe files which will replace the harness files.
1111
The downside is that you have to manually change the icon (or whatever manual editing is required) each time a new netbeans version is used as sdk base. See the `resources/` folder for more information on that.
12-
> Note: Fortunately it must not be that the .exe files are changed aswell, but look into it.
12+
> Note: Fortunately it doesn't have to be that the .exe files are changed aswell, so just look into it.
1313
1414
To prevent patching an older version onto a newer netbeans we have the override.properties,
15-
They define an `beforeHash`and an `afterHash` for each file. Before is the official netbeans source and after is our own patch file (we use this to detect an already patched file/unauthorized changes to *THIS* folder.)
15+
They define an `beforeHash`and an `afterHash` for each file.
16+
Before is the official netbeans source and after is our own patch file (we use this to detect an already patched file/unauthorized changes to _THIS_ folder.)
1617

1718
How do I generate such a hash? Those are SHA-256 hashes and either you make the build fail and see what gradle outputs or you issue `shasum -a 256 harness-override/*.exe` to print them out.

resources/README.md

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,35 @@
11
## What does this folder do?
2-
This folder is no common resources/ folder as in it’d be processed by the build process.
3-
This is just for the sole purpose of storing the downsampled Icons and other resources so you don’t have to do this all over again.
2+
This folder is no common `resources/` folder as in it’d be processed by the build process.
3+
This is just for the sole purpose of storing the downsampled icons and other resources so you don’t have to create them all over again.
44

55
### HOW TO properly generate Icons
6-
The process of generating Icons shouldn't be necessary but who knows what the future brings.
7-
You basically have on large file (256x256px) with 32bit color-depth and have to downsample that for .ico's
6+
The process of generating icons shouldn't be necessary at all but who knows what the future brings.
7+
You basically have one large file (256x256px) with 32bit color-depth and have to downsample that to say 128, 48, 32 and 16px.
88

99
Windows Icons contain multiple images with different resolutions to pick them based on the platform.
10-
I included a GIMP project file, however feel free what Software you'd use.
10+
I included a GIMP project file, however feel free to use what Software you'd use.
1111

1212
Essentially you have to create different layers and then the GIMP Exporter (Export -> Windows Icon) does all the work for you.
1313
See here for the correct configuration:
1414

1515
![Icon Export](icon_export_settings.png)
1616

1717
### HOW TO Replace Icons:
18-
When a new Netbeans Version is out you might need to redo this process since we override netbeans launcher exe with our version (and this launcher can change with a new nb version).
18+
When a new Netbeans version is out you might need to redo this process since we override netbeans' launcher files with our version (and this launcher can change with a new Netbeans version).
1919
See `harness-override/README.md` for more information on that subject.
2020

21-
Open up `app.exe`, `app64.exe` and `pre7_app.exe` (*not* `pre7_app_w.exe`*!!*) with the `Resource Hacker` Software (or comparable).
22-
Open up the `Icon Group (100: 1033)` and Right-Click on it to select `Replace Icon`.
21+
Open up `app.exe`, `app64.exe` and `pre7_app.exe` (_not_ `pre7_app_w.exe`_!!_) with the `Resource Hacker` Software (or comparable).
22+
Open up the `Icon Group (100: 1033)` and Rightclick on it to select `Replace Icon`.
2323
Select `jmonkeyplatform.ico` and you’re done. (Well, save the file ;))
2424

25-
Note: Your Windows has an Icon Cache so you can’t see that it actually worked.
26-
Simply launch `ie4uinit.exe -ClearIconCache` and it should work.
25+
Note: Your Windows System has an Icon Cache so you can’t see that it actually worked.
26+
Simply launch `ie4uinit.exe -ClearIconCache` and you should see the differences.
2727

28-
[There’s](http://www.sevenforums.com/tutorials/49819-icon-cache-rebuild.html) a larger tutorial but it shouldn’t be necessary.
28+
[There’s](http://www.sevenforums.com/tutorials/49819-icon-cache-rebuild.html) a larger tutorial but it shouldn’t be necessary.
2929

30-
When you’ve changed the Icon, make sure to change the hashes in `harness-override/override.properties`
31-
You have the „hashBefore“ and „hashAfter“. The first one is the plain .exe before changing (This is so we can see if there’s a new netbeans version without us having changed the icons/exe) and the other one is after changing. Simple, huh?
30+
When you’ve changed the icon, make sure to change the hashes in `harness-override/override.properties`.
31+
You have the „hashBefore“ and „hashAfter“.
32+
The first one is the plain `.exe` before changing (This is so we can see if there’s a new NetBeans version without us having changed the icons/exe) and the other one is after changing. Simple, huh?
3233

33-
Then issue `shasum -a 256 netbeans/harness/launchers/*.exe` so you have all the hashBefore’s / After’s
34+
Then issue `shasum -a 256 netbeans/harness/launchers/*.exe` so you have all the hashBefore’s / After’s
3435
See `harness-override/README.md` for more information on that subject.

0 commit comments

Comments
 (0)