test: add failing test for EOA admin key validation issue #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test demonstrates that when an EOA's own address is used as the publicKey for an admin key (which happens when using the EOA's private key to create the admin key), the validation fails due to a recursive validation loop in the signature checking logic. The issue occurs because: 1. unwrapAndValidateSignature extracts the inner signature 2. For Secp256k1 keys, it calls isValidSignatureNowCalldata with the EOA address 3. Since the EOA has code (via EIP-7702), it calls isValidSignature on the EOA 4. This triggers the 64/65 byte special case expecting raw EOA signature 5. But the signature is EIP-712 formatted, causing validation to fail
joshieDo
force-pushed
the
test/eoa-admin-key-validation-issue
branch
from
6af630f to
6474ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.