chore: remove vestigial environment variables#1078
Merged
Conversation
Member
coreyfarrell
left a comment
coreyfarrell
left a comment
There was a problem hiding this comment.
I think this is a good idea but it needs to wait, we're not ready to merge breaking changes yet. I think we'll need to mark this as:
BREAKING CHANGE: Remove NYC_ROOT_ID and NYC_INSTRUMENTER environmental variables.
BREAKING CHANGE: The `root` field has been removed from processinfo files.
Although unlikely people are using these environment variables or the field of processinfo files they could be so I'd rather play it safe, just defer this change to 15.0.0.
This removes the NYC_ROOT_ID and NYC_INSTRUMENTER environment variables, which are no longer used or necessary. BREAKING CHANGE: Remove NYC_ROOT_ID and NYC_INSTRUMENTER environmental variables. BREAKING CHANGE: The `root` field has been removed from processinfo files.
isaacs
force-pushed
the
prune-old-environs
branch
from
04372b4 to
02f4f16
Compare
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the NYC_ROOT_ID and NYC_INSTRUMENTER environment variables, which are no longer used or necessary.
Probably best to leave NYC_CWD in place, since it's more load-bearing, and is sometimes inspected in user code to determine whether or not they're being covered by NYC.