changed pidfile location because of security vulnerability, debian bug #631912

Author: irmen

Pyro/ext/daemonizer.py

@@ -47,7 +47,9 @@ class Daemonizer:
     """
     def __init__(self, pidfile=None):
         if not pidfile:
-            self.pidfile = "/tmp/%s.pid" % self.__class__.__name__.lower()
+            # PID file moved out of /tmp to avoid security vulnerability
+            # changed by Debian maintainer per Debian bug #631912
+            self.pidfile = "/var/run/pyro-%s.pid" % self.__class__.__name__.lower()
         else:
             self.pidfile = pidfile
 
@@ -121,12 +123,16 @@ def main_loop(self):
 
     def process_command_line(self, argv, verbose=1):
         usage = "usage:  %s  start | stop | restart | status | debug " \
+                "[--pidfile=...] " \
                 "(run as non-daemon)" % os.path.basename(argv[0])
         if len(argv) < 2:
             print usage
             raise SystemExit
         else:
             operation = argv[1]
+            if len(argv) > 2 and argv[2].startswith('--pidfile=') and \
+                len(argv[2]) > len('--pidfile='):
+                self.pidfile = argv[2][len('--pidfile='):]
         pid = self.get_pid()
         if operation == 'status':
             if self.is_process_running():