Add get commands to Slackbot

Author: iranianpep

src/Slackbot/AbstractCommandContainer.php

@@ -19,6 +19,7 @@ public function get($key)
         $commands = $this->getAll($key);
 
         if (!array_key_exists($key, $commands)) {
+            /** @noinspection PhpInconsistentReturnPointsInspection */
             return;
         }
 

src/Slackbot/Slackbot.php

@@ -15,6 +15,7 @@ class Slackbot
 {
     private $request;
     private $config;
+    private $commands;
 
     /**
      * Slackbot constructor.
@@ -57,10 +58,9 @@ public function setRequest($request)
     /**
      * @param null $key
      *
-     * @throws \Exception
-     *
      * @return mixed
      */
+    /** @noinspection PhpInconsistentReturnPointsInspection */
     public function getRequest($key = null)
     {
         if ($key === null) {
@@ -268,4 +268,24 @@ public function setConfig(Config $config)
     {
         $this->config = $config;
     }
+
+    /**
+     * @return array
+     */
+    public function getCommands()
+    {
+        if (!isset($this->commands)) {
+            $this->setCommands((new CommandContainer())->getAll());
+        }
+
+        return $this->commands;
+    }
+
+    /**
+     * @param array $commands
+     */
+    public function setCommands(array $commands)
+    {
+        $this->commands = $commands;
+    }
 }

src/Slackbot/plugin/help/Help.php

@@ -3,7 +3,6 @@
 namespace Slackbot\plugin\help;
 
 use Slackbot\Command;
-use Slackbot\CommandContainer;
 use Slackbot\plugin\AbstractPlugin;
 use Slackbot\utility\FormattingUtility;
 
@@ -17,7 +16,7 @@ class Help extends AbstractPlugin
      */
     public function index()
     {
-        $allCommands = (new CommandContainer())->getAll();
+        $allCommands = $this->getSlackbot()->getCommands();
 
         $response = '';
         if (!empty($allCommands)) {

src/tests/CommandContainerTest.php

@@ -21,6 +21,7 @@ public function testGet()
 
         $this->assertTrue($commandObject instanceof Command);
 
+        /** @noinspection PhpUndefinedMethodInspection */
         $this->assertEquals($commandObject->getPlugin(), 'Ping');
     }
 
@@ -30,6 +31,7 @@ public function testGet()
     public function testGetAll()
     {
         $commands = (new CommandContainer())->getAll();
+        /** @noinspection PhpUndefinedMethodInspection */
         $this->assertEquals($commands['ping']->getPlugin(), 'Ping');
     }
 }

src/tests/CommandTest.php

@@ -2,12 +2,22 @@
 
 namespace Slackbot;
 
+/** @noinspection PhpUndefinedClassInspection */
 class CommandTest extends \PHPUnit_Framework_TestCase
 {
+    const PING_KEY = 'ping';
+
     public function testGetAction()
     {
-        $command = new Command('ping');
+        $command = new Command(self::PING_KEY);
 
         $this->assertEquals(Command::DEFAULT_ACTION, $command->getAction());
     }
+
+    public function testGetKey()
+    {
+        $command = new Command(self::PING_KEY);
+
+        $this->assertEquals(self::PING_KEY, $command->getKey());
+    }
 }

src/tests/ConfigTest.php

@@ -8,8 +8,6 @@
  * Class ConfigTest.
  */
 
-/** @noinspection PhpUndefinedClassInspection */
-
 /** @noinspection PhpUndefinedClassInspection */
 class ConfigTest extends \PHPUnit_Framework_TestCase
 {

src/tests/SlackbotTest.php

@@ -209,13 +209,15 @@ private function outputOnNoCommand($message)
 
         if (!empty($defaultCommand)) {
             $commandObject = (new CommandContainer())->get($defaultCommand);
+            /** @noinspection PhpUndefinedMethodInspection */
             $commandClass = $commandObject->getClass();
 
             /**
              * @var AbstractPlugin
              */
             $pluginObject = (new $commandClass($slackbot));
 
+            /** @noinspection PhpUndefinedMethodInspection */
             return $pluginObject->index();
         }