-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix: RM: Improve init RM message and fix final memory value. #9470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: RM: Improve init RM message and fix final memory value. #9470
Conversation
BigLep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ajnavarro. I'm wondering if we should have a message where the resource manager is enabled or not. Something like:
"go-libp2p resource protection disabled"
It emphasizes the purpose (node protection) and makes it clear when someone is forgoing that protectin.
682be6b to
0c6f669
Compare
|
@BigLep added a message when starting the daemon and RM is disabled. |
Signed-off-by: Antonio Navarro Perez <[email protected]>
Co-authored-by: Piotr Galar <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
0c6f669 to
cef695f
Compare
Signed-off-by: Antonio Navarro Perez <[email protected]>
cef695f to
6b0b7a0
Compare
Jorropo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
|
(unrelated) @ajnavarro if you have multiple "wip" commits like https://github.com/ipfs/kubo/pull/9470/commits it is perfectly fine to just squash-merge :) (makes eyeballing https://github.com/ipfs/kubo/commits/master and inspecting release diff a bit easier for person making the release dance) |
Improved init message explaining what RM is doing. Output example:
Also fixed the computed memory value. When calling
Scale(int64(maxMemory), int(numFD))method we were adding that memory to the previously configured one at System level. Setting System memory and FD to libp2p default ones. Output example using 8GB as set memory now:Signed-off-by: Antonio Navarro Perez [email protected]