Skip to content

Improve defaults in Swarm.ConnMgr #8845

@lidel

Description

@lidel
  • switch Swarm.ConnMgr config from hardcoded strings to optional types:
    *OptionalString  `json:",omitempty"` // type
    *OptionalInteger `json:",omitempty"` // low|high water
    *OptionalDuration `json:",omitempty"` // graceperiod
    • this allows us to be backward-compatible, but remove default values from user config, enabling us to adjust implicit default over time
    • prior art – see how we use fields from Swarm.RelayService
  • (TBD) change the defaults to something lower (prior art: ipfs-desktop – but we can discuss new implicit defaults on the PR, and decide to not change them for now)

Metadata

Metadata

Assignees

Labels

P1High: Likely tackled by core team if no one steps uphelp wantedSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featuretopic/configTopic config

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions