fix: start webrtc sigserve during tests so browsers can dial things

Author: achingbrain

.aegir.js

@@ -3,10 +3,12 @@
 const IPFSFactory = require('ipfsd-ctl')
 const MockPreloadNode = require('./test/utils/mock-preload-node')
 const EchoServer = require('interface-ipfs-core/src/utils/echo-http-server')
+const webRTCStarSigServer = require('libp2p-webrtc-star/src/sig-server')
 
 const ipfsdServer = IPFSFactory.createServer()
 const preloadNode = MockPreloadNode.createNode()
 const echoServer = EchoServer.createServer()
+let sigServer
 
 module.exports = {
   bundlesize: { maxSize: '652kB' },
@@ -42,11 +44,16 @@ module.exports = {
           await ipfsdServer.start()
           await preloadNode.start()
           await echoServer.start()
+          sigServer = await webRTCStarSigServer.start({
+            host: '127.0.0.1',
+            port: 14579
+          })
       },
       post: async () => {
           await ipfsdServer.stop()
           await preloadNode.stop()
           await echoServer.stop()
+          await sigServer.stop()
       }
     }
   }

src/core/components/id.js

@@ -12,7 +12,17 @@ module.exports = ({ peerInfo }) => {
       publicKey: peerInfo.id.pubKey.bytes.toString('base64'),
       addresses: peerInfo.multiaddrs
         .toArray()
-        .map(ma => `${ma}/p2p/${id}`)
+        .map(ma => {
+          const str = ma.toString()
+
+          // some relay-style transports add our peer id to the ma for us
+          // so don't double-add
+          if (str.endsWith(`/p2p/${id}`)) {
+            return str
+          }
+
+          return `${str}/p2p/${id}`
+        })
         .sort()
         .map(ma => multiaddr(ma)),
       agentVersion: `js-ipfs/${pkgversion}`,

test/core/interface.spec.js

@@ -4,7 +4,7 @@
 const tests = require('interface-ipfs-core')
 const merge = require('merge-options')
 const { createFactory } = require('ipfsd-ctl')
-const { isNode } = require('ipfs-utils/src/env')
+const { isNode, isBrowser } = require('ipfs-utils/src/env')
 const IPFS = require('../../src')
 
 /** @typedef { import("ipfsd-ctl").ControllerOptions } ControllerOptions */
@@ -23,7 +23,16 @@ describe('interface-ipfs-core tests', function () {
       ref: require('ipfs-http-client')
     },
     ipfsOptions: {
-      pass: 'ipfs-is-awesome-software'
+      pass: 'ipfs-is-awesome-software',
+      ...(isBrowser ? {
+        config: {
+          Addresses: {
+            Swarm: [
+              '/ip4/127.0.0.1/tcp/14579/wss/p2p-webrtc-star'
+            ]
+          }
+        }
+      } : {})
     }
   }
   const overrides = {

test/utils/factory.js

@@ -1,6 +1,7 @@
 'use strict'
 const { createFactory } = require('ipfsd-ctl')
 const merge = require('merge-options')
+const { isBrowser } = require('ipfs-utils/src/env')
 
 const factory = (options, overrides) => createFactory(
   merge({
@@ -18,6 +19,19 @@ const factory = (options, overrides) => createFactory(
   merge({
     js: {
       ipfsBin: './src/cli/bin.js'
+    },
+    proc: {
+      ...(isBrowser ? {
+        ipfsOptions: {
+          config: {
+            Addresses: {
+              Swarm: [
+                '/ip4/127.0.0.1/tcp/14579/wss/p2p-webrtc-star'
+              ]
+            }
+          }
+        }
+      } : {})
     }
   }, overrides)
 )