fix(types): Add missing types #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
changed the title
achingbrain
changed the title
achingbrain
approved these changes
Apr 16, 2023
Member
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
LGTM, just a small type change required.
Interesting that this rule didn't pick this up before. Any ideas why?
Co-authored-by: Alex Potsides <[email protected]>
Contributor
Author
|
@achingbrain yep, I dunno why it didn't get caught, looks like a bug in that rule. |
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
## [helia-v1.0.4](helia-v1.0.3...helia-v1.0.4) (2023-05-04) ### Bug Fixes * **types:** Add missing types ([#95](#95)) ([e858b8d](e858b8d)) ### Dependencies * **dev:** bump libp2p from 0.43.4 to 0.44.0 ([#96](#96)) ([6e37d9f](6e37d9f)) ### Trivial Changes * bump aegir from 38.1.8 to 39.0.4 ([#111](#111)) ([2156568](2156568))
Contributor
|
🎉 This PR is included in version helia-v1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR adding missing return types.