fix issue 6760, adding with hash-only, high CPU usage. #6764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Nov 15, 2019
core/coreapi/unixfs.go
Outdated
| return nilNode,nil | ||
| } | ||
|
|
||
| func CloseFakeRepo() error { |
Member
There was a problem hiding this comment.
I wouldn't bother with this. We don't actually need to close this node.
Stebalien
requested changes
Nov 15, 2019
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
Thanks! Ideally we wouldn't even need a "nil node" but this looks like a good interim solution.
core/coreapi/unixfs.go
Outdated
|
|
||
| type UnixfsAPI CoreAPI | ||
| var nilNode *core.IpfsNode | ||
| var lock sync.Mutex |
use sync.Once instead
Stebalien
approved these changes
Nov 18, 2019
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPFS daemon will create a IDENTITY for repo through function GenerateKeyPairWithReader. This action cost so much CPU resource. And IPFS daemon creates a fake repo for each
ipfs add -n xxx.So, i create a global fake node, all the calls
ipfs add -n xxxcan use this fake node to avoid GenerateKeyPairWithReader.