Skip to content

namesys: set the correct cache TTL on publish #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Stebalien merged 1 commit into from
Sep 23, 2019
Merged

namesys: set the correct cache TTL on publish #6667

Stebalien merged 1 commit into from
Sep 23, 2019

Conversation

@Stebalien
Copy link
Member

@Stebalien Stebalien commented Sep 23, 2019

@github-actions github-actions bot requested a review from dirkmc September 23, 2019 21:08
@Stebalien
Copy link
Member Author

Stebalien commented Sep 23, 2019

cc @postables.

@dirkmc
Copy link
Contributor

dirkmc commented Sep 23, 2019

Conceptually it LGTM 👍

Is this still considered experimental?
https://github.com/ipfs/go-ipfs/blob/1a32379c998f706c1bc7751fc8326f4f4a63f778/namesys/publisher.go#L200-L211

@Stebalien
Copy link
Member Author

Stebalien commented Sep 23, 2019

Is this still considered experimental?

No but I started going down the rabbit hole of fixing the interfaces and stopped myself.

@Stebalien Stebalien merged commit 2062738 into master Sep 23, 2019
@dirkmc
Copy link
Contributor

dirkmc commented Sep 23, 2019

A wise choice :)

@kpp
Copy link

kpp commented Sep 23, 2019

How do I test the fix?

@Stebalien
Copy link
Member Author

Stebalien commented Sep 23, 2019

@kpp:

  1. Build the latest master.
  2. Run ipfs name publish --ttl=10m YYY.
  3. Try running ipfs name resolve YYY. That should continue to work for 10 minutes.

However, this doesn't resolve #6656. It only resolves #6656 (comment).

@Stebalien Stebalien deleted the fix/ttl-on-publish branch September 23, 2019 22:44
This was referenced Jan 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dirkmc dirkmc Awaiting requested review from dirkmc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offline ipns record lives for 1m only

4 participants

@Stebalien @dirkmc @kpp