Skip to content

Commit e74d783

Browse files
hacdiaslidel
andauthored
chore: apply suggestions from review
Co-authored-by: Marcin Rataj <[email protected]>
1 parent bd58502 commit e74d783

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tests/t0118_gateway_car_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ func TestGatewayCarPathing(t *testing.T) {
1818
{
1919
Name: "GET default CAR response with pathing through UnixFS Directory",
2020
Hint: `
21-
CAR stream is not deterministic, as blocks can arrive in random order,
22-
but if we have a small file that fits into a single block, and export its CID
23-
we will get a CAR that is a deterministic array of bytes.
21+
CAR stream of a UnixFS file within a path under UnixFS subdirectory should contain
22+
all the blocks to traverse the path, as well as all the blocks behind
23+
the last path segment (terminating entity returned recursively).
2424
`,
2525
Request: Request().
2626
Path("/ipfs/{{cid}}/subdir/ascii.txt", subdirTwoSingleBlockFilesFixture.MustGetCid()).
@@ -40,7 +40,7 @@ func TestGatewayCarPathing(t *testing.T) {
4040
),
4141
},
4242
{
43-
Name: "GET default CAR response of UnixFS file on a path with sharded directory",
43+
Name: "GET default CAR response of UnixFS file on a path with HAMT-sharded directory",
4444
Hint: `
4545
CAR stream of a UnixFS file within a path with sharded directory should contain
4646
all the blocks to traverse the path, as well as all the blocks contained inside

tooling/helpers/car.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func applyStandardCarResponseHeaders(t *testing.T, st test.SugarTest) test.Sugar
2525
// Hint("CAR is streamed, gateway may not have the entire thing, unable to calculate total size").
2626
// IsEmpty(),
2727
test.Header("X-Content-Type-Options").
28-
Hint("CAR is streamed, gateway may not have the entire thing, unable to calculate total size").
28+
Hint("Content type sniffing should be explicitly disabled via nosniff header.").
2929
Equals("nosniff"),
3030
test.Header("Accept-Ranges").
3131
Hint("CAR is streamed, gateway may not have the entire thing, unable to support range-requests. Partial downloads and resumes should be handled using IPLD selectors: https://github.com/ipfs/go-ipfs/issues/8769").

0 commit comments

Comments
 (0)