Skip to content

Commit e3effd8

Browse files
minor html fixes removing type from javascript or css files, adding meta info and viewport information
1 parent 606efa9 commit e3effd8

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

html/html/themes/ipfire/include/functions.pl

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
# @param submenu entries
4040
sub showsubmenu() {
4141
my $submenus = shift;
42-
42+
4343
print "<ul>";
4444
foreach my $item (sort keys %$submenus) {
4545
$link = getlink($submenus->{$item});
@@ -126,23 +126,26 @@ sub openpage {
126126
<title>$headline - $title</title>
127127
$extrahead
128128
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
129+
<meta name="viewport" content="width=device-width, initial-scale=1">
130+
<meta name="theme-color" content="#E12917"/>
131+
<meta name="Description" content="$settings{'HOSTNAME'}.$settings{'DOMAINNAME'}">
129132
<link rel="shortcut icon" href="/favicon.ico" />
130-
<script type="text/javascript" src="/include/jquery.js"></script>
133+
<script src="/include/jquery.js"></script>
131134
132-
<script type="text/javascript">
135+
<script>
133136
function swapVisibility(id) {
134137
\$('#' + id).toggle();
135138
}
136139
</script>
137140
END
138141

139142
foreach my $stylesheet (@stylesheets) {
140-
print "<link href=\"/themes/ipfire/include/css/$stylesheet\" rel=\"stylesheet\" type=\"text/css\" />\n";
143+
print "<link href=\"/themes/ipfire/include/css/$stylesheet\" rel=\"stylesheet\" />\n";
141144
}
142145

143146
if ($settings{'SPEED'} ne 'off') {
144147
print <<END
145-
<script type="text/javascript" src="/themes/ipfire/include/js/refreshInetInfo.js"></script>
148+
<script src="/themes/ipfire/include/js/refreshInetInfo.js"></script>
146149
END
147150
;
148151
}
@@ -152,8 +155,8 @@ END
152155
<body>
153156
<div id="header" class="fixed">
154157
<div id="logo">
155-
<a href="https://www.ipfire.org" style="text-decoration: none;">
156-
<img src="/themes/ipfire/images/tux2.png" style="float:left; margin-left: -3px; margin-top: -3px;"/>
158+
<a href="https://www.ipfire.org" aria-label="ipfire logo" style="text-decoration: none;">
159+
<img src="/themes/ipfire/images/tux2.png" alt="ipfire logo" style="float:left; margin-left: -3px; margin-top: -3px;"/>
157160
END
158161
;
159162
if ($settings{'WINDOWWITHHOSTNAME'} ne 'off') {

0 commit comments

Comments
 (0)