fix(icon): load base64 data urls #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
reviewed
Feb 1, 2023
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Is it worthwhile to add a test with a CSP policy enabled?
Contributor
Author
|
@liamdebeasi there is already: https://github.com/ionic-team/ionicons/tree/FW-3116/src/components/test/csp which validates that a SVG loads with a CSP policy and the utf8 data encoded url. |
liamdebeasi
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in: #1141
I had incorrectly assumed that all data-url usage formats were consistent. This was not the case.
Developers use the base64 data-url format to pass encoded image strings to the
ion-iconcomponent. This is different than how ionicons inlines SVG images; where the entire SVG element is encoded in the data-url.This PR reintroduces support for the base64 data-url format by only applying the patch for CSP/data parser when the data url includes
utf8encoding. Otherwise it will fallback to the previous implementation pattern and load the asset (as long as the CSP allows it).