fix(modal, popover): respect safe area insets on popovers and modals #18215
Annotations
7 errors and 1 notice
|
Run /./.github/workflows/actions/test-core-screenshot
Process completed with exit code 1.
|
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/popover/test/safe-area/popover.e2e.ts#L82
6) [Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:64:9 › popover: safe-area - md/ltr › should handle a large popover near the bottom-right corner without overlapping safe areas
Error: A snapshot doesn't exist at /ionic/src/components/popover/test/safe-area/popover.e2e.ts-snapshots/popover-safe-area-large-md-ltr-Mobile-Chrome-linux.png, writing actual.
80 | await ionPopoverDidPresent.next();
81 |
> 82 | await expect(page).toHaveScreenshot(screenshot('popover-safe-area-large'));
| ^
83 | });
84 | });
85 | });
at /ionic/src/components/popover/test/safe-area/popover.e2e.ts:82:7
|
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/popover/test/safe-area/popover.e2e.ts#L61
5) [Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:39:9 › popover: safe-area - md/ltr › should not overlap the right safe area when trigger is near the right edge
Error: A snapshot doesn't exist at /ionic/src/components/popover/test/safe-area/popover.e2e.ts-snapshots/popover-safe-area-right-md-ltr-Mobile-Chrome-linux.png, writing actual.
59 | await ionPopoverDidPresent.next();
60 |
> 61 | await expect(page).toHaveScreenshot(screenshot('popover-safe-area-right'));
| ^
62 | });
63 |
64 | test('should handle a large popover near the bottom-right corner without overlapping safe areas', async ({
at /ionic/src/components/popover/test/safe-area/popover.e2e.ts:61:7
|
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/popover/test/safe-area/popover.e2e.ts#L36
4) [Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:14:9 › popover: safe-area - md/ltr › should not overlap the bottom safe area when trigger is near the bottom edge
Error: A snapshot doesn't exist at /ionic/src/components/popover/test/safe-area/popover.e2e.ts-snapshots/popover-safe-area-bottom-md-ltr-Mobile-Chrome-linux.png, writing actual.
34 | await ionPopoverDidPresent.next();
35 |
> 36 | await expect(page).toHaveScreenshot(screenshot('popover-safe-area-bottom'));
| ^
37 | });
38 |
39 | test('should not overlap the right safe area when trigger is near the right edge', async ({
at /ionic/src/components/popover/test/safe-area/popover.e2e.ts:36:7
|
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/popover/test/safe-area/popover.e2e.ts#L82
3) [Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:64:9 › popover: safe-area - ios/ltr › should handle a large popover near the bottom-right corner without overlapping safe areas
Error: A snapshot doesn't exist at /ionic/src/components/popover/test/safe-area/popover.e2e.ts-snapshots/popover-safe-area-large-ios-ltr-Mobile-Chrome-linux.png, writing actual.
80 | await ionPopoverDidPresent.next();
81 |
> 82 | await expect(page).toHaveScreenshot(screenshot('popover-safe-area-large'));
| ^
83 | });
84 | });
85 | });
at /ionic/src/components/popover/test/safe-area/popover.e2e.ts:82:7
|
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/popover/test/safe-area/popover.e2e.ts#L61
2) [Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:39:9 › popover: safe-area - ios/ltr › should not overlap the right safe area when trigger is near the right edge
Error: A snapshot doesn't exist at /ionic/src/components/popover/test/safe-area/popover.e2e.ts-snapshots/popover-safe-area-right-ios-ltr-Mobile-Chrome-linux.png, writing actual.
59 | await ionPopoverDidPresent.next();
60 |
> 61 | await expect(page).toHaveScreenshot(screenshot('popover-safe-area-right'));
| ^
62 | });
63 |
64 | test('should handle a large popover near the bottom-right corner without overlapping safe areas', async ({
at /ionic/src/components/popover/test/safe-area/popover.e2e.ts:61:7
|
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/popover/test/safe-area/popover.e2e.ts#L36
1) [Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:14:9 › popover: safe-area - ios/ltr › should not overlap the bottom safe area when trigger is near the bottom edge
Error: A snapshot doesn't exist at /ionic/src/components/popover/test/safe-area/popover.e2e.ts-snapshots/popover-safe-area-bottom-ios-ltr-Mobile-Chrome-linux.png, writing actual.
34 | await ionPopoverDidPresent.next();
35 |
> 36 | await expect(page).toHaveScreenshot(screenshot('popover-safe-area-bottom'));
| ^
37 | });
38 |
39 | test('should not overlap the right safe area when trigger is near the right edge', async ({
at /ionic/src/components/popover/test/safe-area/popover.e2e.ts:36:7
|
|
Run /./.github/workflows/actions/test-core-screenshot
6 failed
[Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:14:9 › popover: safe-area - ios/ltr › should not overlap the bottom safe area when trigger is near the bottom edge
[Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:39:9 › popover: safe-area - ios/ltr › should not overlap the right safe area when trigger is near the right edge
[Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:64:9 › popover: safe-area - ios/ltr › should handle a large popover near the bottom-right corner without overlapping safe areas
[Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:14:9 › popover: safe-area - md/ltr › should not overlap the bottom safe area when trigger is near the bottom edge
[Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:39:9 › popover: safe-area - md/ltr › should not overlap the right safe area when trigger is near the right edge
[Mobile Chrome] › src/components/popover/test/safe-area/popover.e2e.ts:64:9 › popover: safe-area - md/ltr › should handle a large popover near the bottom-right corner without overlapping safe areas
4 skipped
521 passed (3.8m)
|
Loading