Skip to content

Conversation

@ItsChaceD
Copy link
Contributor

@ItsChaceD ItsChaceD commented Nov 11, 2025

  • Updated NPM dependencies across all plugins and root package, including major version upgrade to typescript (5.9.3). Prettier updates will be in a separate PR
  • Verified all plugins build successfully and have no peer dependency conflicts

@ItsChaceD ItsChaceD requested a review from a team November 11, 2025 22:44
@ItsChaceD ItsChaceD marked this pull request as draft November 11, 2025 22:47
@ItsChaceD ItsChaceD marked this pull request as ready for review November 11, 2025 23:53
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ionic/prettier-config, prettier and prettier-plugin-java should be updated. The npx @capacitor/plugin-migration-v6-to-v7@latest command should be able to assist you with the required changes.
Or you can check ionic-team/create-capacitor-plugin@2fa0317 for manual changes
and probably this too https://github.com/ionic-team/create-capacitor-plugin/pull/123/files

Since you updated the actions to not use esm you can probably remove the dependency

@ItsChaceD
Copy link
Contributor Author

ItsChaceD commented Nov 12, 2025

@ionic/prettier-config, prettier and prettier-plugin-java should be updated. The npx @capacitor/plugin-migration-v6-to-v7@latest command should be able to assist you with the required changes. Or you can check ionic-team/create-capacitor-plugin@2fa0317 for manual changes and probably this too ionic-team/create-capacitor-plugin#123 (files)

Since you updated the actions to not use esm you can probably remove the dependency

If we upgrade those to their latest versions then it results in 100+ code changes when linting and I wasn't sure if we wanted to do that days before a beta release. Yes they should all just be style / cosmetic changes, but didn't know if we wanted to take that risk. I also wanted to discuss and potentially add it to a separate PR so that it doesn't add too much noise to this PR review.

Unless you are only talking about doing minor upgrades and adding the prettier-plugin-java command to the fmt script?

Thoughts?

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Released dev build of text-zoom with dev version: 8.0.0-dev-2440-20251114T170558.0

@github-actions
Copy link

Released dev build of text-zoom with dev version: 8.0.0-dev-2440-20251112T164359.0

@jcesarmobile
Copy link
Member

I mean major updates, not minor, if you do a minor then the prettier-plugin-java command on the npm script is not needed as it's needed on version 2 of prettier-plugin-java.

I'm ok on doing it in a separate PR, but the changes on the root package.json are also unrelated to the original task, so would be good to also move them to a separate PR.

@ItsChaceD
Copy link
Contributor Author

I mean major updates, not minor, if you do a minor then the prettier-plugin-java command on the npm script is not needed as it's needed on version 2 of prettier-plugin-java.

I'm ok on doing it in a separate PR, but the changes on the root package.json are also unrelated to the original task, so would be good to also move them to a separate PR.

Opened #2443 (root npm updates) and #2444 (prettier updates)

@eric-horodyski eric-horodyski merged commit 4c05924 into main Nov 14, 2025
24 checks passed
@eric-horodyski eric-horodyski deleted the chore/RMET-4693/upgrade-npm-dependencies branch November 14, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants