-
Notifications
You must be signed in to change notification settings - Fork 663
chore: upgrade npm dependencies for all plugins #2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade npm dependencies for all plugins #2440
Conversation
jcesarmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ionic/prettier-config, prettier and prettier-plugin-java should be updated. The npx @capacitor/plugin-migration-v6-to-v7@latest command should be able to assist you with the required changes.
Or you can check ionic-team/create-capacitor-plugin@2fa0317 for manual changes
and probably this too https://github.com/ionic-team/create-capacitor-plugin/pull/123/files
Since you updated the actions to not use esm you can probably remove the dependency
If we upgrade those to their latest versions then it results in 100+ code changes when linting and I wasn't sure if we wanted to do that days before a beta release. Yes they should all just be style / cosmetic changes, but didn't know if we wanted to take that risk. I also wanted to discuss and potentially add it to a separate PR so that it doesn't add too much noise to this PR review. Unless you are only talking about doing minor upgrades and adding the Thoughts? |
|
Released dev build of text-zoom with dev version: 8.0.0-dev-2440-20251114T170558.0 |
|
Released dev build of text-zoom with dev version: 8.0.0-dev-2440-20251112T164359.0 |
|
I mean major updates, not minor, if you do a minor then the I'm ok on doing it in a separate PR, but the changes on the root package.json are also unrelated to the original task, so would be good to also move them to a separate PR. |
Opened #2443 (root npm updates) and #2444 (prettier updates) |
5.9.3). Prettier updates will be in a separate PR