Annotate uu-internal links #316
Conversation
obsoletes the pdf-interwiki link
chris34
left a comment
chris34
left a comment
There was a problem hiding this comment.
Just wanted to cherry-pick the two commits into the interwikilink PR, but then i stumbled upon some things…
| padding-left: 18px; | ||
| } | ||
| a[href^="https://forum.ubuntuusers.de/post/"] { | ||
| background-image: url(../img/icon_minipost.gif); |
There was a problem hiding this comment.
IMHO this will display the minipost-gif two times beneath a forum post, as there the current minipost-icon is includeded via <img> https://github.com/inyokaproject/theme-ubuntuusers/blob/staging/inyoka_theme_ubuntuusers/templates/forum/topic.html#L288
I dont know if :not(.postinfo) a[href^=…] or something like this could help.
(For interwikilinks this should be working, as they also use a background-image. Nevertheless, it could confuse users, if there exists also an interwikilink for the same url, but with a different icon.)
There was a problem hiding this comment.
IMHO this will display the minipost-gif two times beneath a forum post, as there the current minipost-icon is includeded via
<img>https://github.com/inyokaproject/theme-ubuntuusers/blob/staging/inyoka_theme_ubuntuusers/templates/forum/topic.html#L288
True
I dont know if
:not(.postinfo) a[href^=…]or something like this could help.
AFAIK (with :not) you can't select (an attribute of) a parent. We could just remove the img and permalink the full date (which is better usability IMO)
(For interwikilinks this should be working, as they also use a
background-image. Nevertheless, it could confuse users, if there exists also an interwikilink for the same url, but with a different icon.)
| a.search { | ||
| background-image: url(../img/interwiki/search.png); | ||
| } | ||
| a[href^="https://wiki.ubuntuusers.de/"] { |
There was a problem hiding this comment.
I question, if hardcoding domains is good.
There was a problem hiding this comment.
In this case the line is kind of a fallback.
In case the user uses the [:wiki:] syntax, the usual css styling applies - or can we apply (we currently don't), with no hardcoded domain.
In case the user uses the generic link syntax (and "hardcodes" the domain), we can still apply the styling by hardcoding the domain too.
Based on #205 and adds annotations for wiki, post, topic, forum and github.