Conversation
jrouzierinverse
force-pushed
the
fix/6830
branch
from
51dfa1f to
3c458c4
Compare
3 tasks
fdurand
reviewed
Feb 9, 2022
jrouzierinverse
force-pushed
the
fix/6830
branch
from
3090fc9 to
3c14899
Compare
fdurand
requested changes
Feb 9, 2022
db/upgrade-X.X-X.Y.sql
Outdated
| ALTER TABLE pki_revoked_certs | ||
| ADD COLUMN IF NOT EXISTS `subject` varchar(255) AFTER crl_reason; | ||
|
|
||
| DELIMITER / |
Member
There was a problem hiding this comment.
Add comment like ! echo "blablabla"
db/upgrade-X.X-X.Y.sql
Outdated
| END / | ||
| DELIMITER ; | ||
|
|
||
| DELIMITER / |
Member
There was a problem hiding this comment.
Add comment like ! echo "blablabla"
db/upgrade-X.X-X.Y.sql
Outdated
| END/ | ||
| DELIMITER ; | ||
|
|
||
| DELIMITER / |
Member
There was a problem hiding this comment.
Add comment like ! echo "blablabla"
db/upgrade-X.X-X.Y.sql
Outdated
| END/ | ||
| DELIMITER ; | ||
|
|
||
| DELIMITER / |
Member
There was a problem hiding this comment.
Add comment like ! echo "blablabla"
…ounting tables to history
fdurand
requested changes
Feb 11, 2022
Member
fdurand
left a comment
fdurand
left a comment
There was a problem hiding this comment.
Remove the procedure and fix the missing admin gui parameters and we will be good to merge.
| # | ||
| # How many session to clean up at a time | ||
| batch=100 | ||
| session_batch=100 |
Member
There was a problem hiding this comment.
needs to be visible from the admin gui
| # | ||
| # How long a session cleanup job can run | ||
| timeout=5s | ||
| session_timeout=5s |
Member
There was a problem hiding this comment.
needs to be visible from the admin gui
| # | ||
| # How long to keep a session open | ||
| window=24h | ||
| session_window=24h |
Member
There was a problem hiding this comment.
needs to be visible from the admin gui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the performance of the bandwidth accounting cleanup process
Impacts
Bandwidh accounting.
Issue
fixes #6830
Delete branch after merge
YES
Checklist
(REQUIRED) - [yes, no or n/a]
NEWS file entries
Enhancements