Skip to content

Comments

Feature/venom upload logs#6784

Merged
nqb merged 11 commits intodevelfrom
feature/venom-upload-logs
Dec 23, 2021
Merged

Feature/venom upload logs#6784
nqb merged 11 commits intodevelfrom
feature/venom-upload-logs

Conversation

@nqb
Copy link
Contributor

@nqb nqb commented Dec 19, 2021 •
edited
Loading

Description

  • Upload Venom logs for test jobs as GitLab artifacts.
  • Remove secrets before upload of logs
  • Disable public pipelines in GitLab
    • Authenticate API calls to GitLab during check stage
    • Cancel pipeline if it's not necessary to run it
  • Retry several times to register/unregister RHEL subscription

Impacts

Delete branch after merge

YES

@nqb nqb force-pushed the feature/venom-upload-logs branch from e4a67a6 to 8b4e3d9 Compare December 19, 2021 09:25
@nqb nqb requested a review from JeGoi December 22, 2021 10:32
@nqb nqb added this to the PacketFence-11.2 milestone Dec 22, 2021
@nqb nqb force-pushed the feature/venom-upload-logs branch from 5f2021b to 9b550e4 Compare December 22, 2021 15:08
JeGoi
JeGoi approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@nqb nqb force-pushed the feature/venom-upload-logs branch 4 times, most recently from fa9b10e to fd56dad Compare December 22, 2021 23:05
JeGoi
JeGoi approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine for me!

@nqb nqb force-pushed the feature/venom-upload-logs branch 2 times, most recently from 3abc51e to 796beda Compare December 23, 2021 07:07
@nqb nqb force-pushed the feature/venom-upload-logs branch 3 times, most recently from d4be730 to 3d31939 Compare December 23, 2021 08:45
nqb added 6 commits December 23, 2021 10:52
@nqb
check psono vars for wireless01 and nodes
92fb5c8 
change logic for secrets removal
@nqb
collect logs on all VM
49f792d
@nqb
improve error handling for EL registration
0948ca5
@nqb
remove deprecated settings
0b52548 
Public pipelines are now disabled.

remove useless setting
@nqb
adjust archive extraction
267e52b
@nqb
authenticate API calls on GitLab
02c2e82 
cancel pipeline if not necessary

avoid to receive notifications for a failed job
@nqb nqb force-pushed the feature/venom-upload-logs branch from 3d31939 to 02c2e82 Compare December 23, 2021 09:52
@nqb
Copy link
Contributor Author

nqb commented Dec 23, 2021

Once merged, I will backport changes to maintenance/11.X branches

@nqb nqb force-pushed the feature/venom-upload-logs branch from ae072da to f80a362 Compare December 23, 2021 13:07
@nqb nqb merged commit 691e16d into devel Dec 23, 2021
@nqb nqb deleted the feature/venom-upload-logs branch December 23, 2021 13:19
nqb added a commit that referenced this pull request Dec 23, 2021
@nqb
tests: apply #6784
fe1f344
nqb added a commit that referenced this pull request Dec 23, 2021
@nqb
tests: apply #6784
6908be2
nqb added a commit that referenced this pull request Dec 24, 2021
@nqb
upload artifacts on failure
9620a50 
missing part of #6784
nqb added a commit that referenced this pull request Dec 24, 2021
@nqb
upload artifacts on failure
94c2aa0 
missing part of #6784
nqb added a commit that referenced this pull request Dec 24, 2021
@nqb
upload artifacts on failure
a5e82a5 
missing part of #6784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeGoi JeGoi JeGoi approved these changes

Assignees

@JeGoi JeGoi

Labels

Status: For review

Projects

None yet

Milestone

PacketFence-11.2

Development

Successfully merging this pull request may close these issues.

2 participants

@nqb @JeGoi