Conversation
|
Fine for me, I'll let @jrouzierinverse comment if necessary and we'll be good to merge |
| body, err := ioutil.ReadAll(req.Body) | ||
| if err != nil { | ||
| Error.Message = err.Error() | ||
| Error.Status = http.StatusInternalServerError |
There was a problem hiding this comment.
Add a break to avoid things continuing
| Error.Status = http.StatusInternalServerError | |
| Error.Status = http.StatusInternalServerError | |
| break |
There was a problem hiding this comment.
I manage the answer with the manageAnswer function, so i need to continue
| } | ||
| if err = json.Unmarshal(body, &o); err != nil { | ||
| Error.Message = err.Error() | ||
| Error.Status = http.StatusInternalServerError |
There was a problem hiding this comment.
Add a break to avoid things continuing
| Error.Status = http.StatusInternalServerError | |
| Error.Status = http.StatusInternalServerError | |
| break |
There was a problem hiding this comment.
I manage the answer with the manageAnswer function, so i need to continue
| } | ||
| if Information, err = o.Resign(vars); err != nil { | ||
| Error.Message = err.Error() | ||
| Error.Status = http.StatusUnprocessableEntity |
There was a problem hiding this comment.
Add a break to avoid things continuing
| Error.Status = http.StatusUnprocessableEntity | |
| Error.Status = http.StatusUnprocessableEntity | |
| break |
There was a problem hiding this comment.
I manage the answer with the manageAnswer function, so i need to continue
| } | ||
|
|
||
| Information.Entries = cadb | ||
| for _, v := range cadb { |
There was a problem hiding this comment.
Why do need the loop?
The logic only handles the first entry of the cadb.
What is happening to the other entries?
There was a problem hiding this comment.
There is only one entry, i get the ca from the db based on the unique id.
|
Looks good to me. |
4 participants
Description
Added a feature to be able to resign the CA
Impacts
PKI
Delete branch after merge
YES
Checklist
NEWS file entries
Enhancements