Test suites for inlinel2 and inlinel3

[fdurand]

Description

Cover test for inlinel3 and inlinel2

Impacts

Tests

Delete branch after merge

YES

[nqb]

I put some single comment during review, I will add here general comments related to the whole test suites:

1. Could you rebase on devel ?
2. We need to have variables for each test suite defined in vars/all.yml
3. When using API calls your JSON payloads contain:
   • default values: could you remove it ?
   • sometimes id key which is not necessary if already present in URL
4. Could you create a diagram for inline L2 ?
5. On diagrams, could you mention where is the PacketFence server to clarify ?
6. [/] I run that scenario on a runner and both test suites failed at Test-if-the-device-is-in-the-ipset-role-ID-2-Guest-role
   • Doesn't seem to be an issue anymore if we run test suites after unit tests https://gitlab.com/inverse-inc/packetfence/-/jobs/1932845215
7. [/] I and @JeGoi will move some test cases into executor to avoid duplication between both test suites
   => will be done later on a specific PR.

I will add another comment later which more specific to the logic of the scenario

[nqb]

Also I suggest to rename test cases without any spaces and uppercase letters because it create long variables (when you want to reuse output from a test case)

EDIT: DONE

[nqb]

At the moment, inline test suites don't require other VM than pf VM so they could be part of unit_tests scenario to speed tests.

EDIT: DONE

[nqb]

Also we should create a connection profile with an inline filter.

EDIT: dependency to default connection profile in /root/register_node so we keep things like this for now.