✅ Fixed unit tests.

Author: intere

GeoTrackKit/Core/GeoTrackManager.swift

@@ -38,7 +38,7 @@ public class GeoTrackManager: NSObject {
 
     /// When we startup, if we find points to be older than this threshold, we toss them away.
     /// Defaults to 5 seconds, but you can adjust this as you see fit.
-    public static var oldPointTimeThreshold: TimeInterval = 5
+    public static var oldPointTimeThreshold: TimeInterval? = 5
 
     // MARK: - GeoTrackService Properties
 
@@ -218,8 +218,10 @@ extension GeoTrackManager {
         // Ensure that the first point is recent (not old points which we often get when tracking begins):
         if lastPoint == nil {
             locations.forEach { location in
-                guard abs(location.timestamp.timeIntervalSinceNow) < GeoTrackManager.oldPointTimeThreshold else {
-                    return
+                if let oldPointTimeThreshold = GeoTrackManager.oldPointTimeThreshold {
+                    guard abs(location.timestamp.timeIntervalSinceNow) < oldPointTimeThreshold else {
+                        return GTDebug(message: "skipping point: \(location)")
+                    }
                 }
                 recentLocations.append(location)
             }

GeoTrackKitExample/GeoTrackKitExampleTests/GeoTrackKit/Core/GeoTrackManagerTests.swift

@@ -12,18 +12,18 @@ import XCTest
 class GeoTrackManagerTests: XCTestCase {
 
     let mockManager = MockLocationManager()
-    var manager: GeoTrackManager?
-    var oldPointTimeThreshold: TimeInterval = GeoTrackManager.oldPointTimeThreshold
+    var subject: GeoTrackManager?
+    var oldPointTimeThreshold: TimeInterval? = GeoTrackManager.oldPointTimeThreshold
 
     override func setUp() {
         super.setUp()
         GeoTrackManager.shared.reset()
         GeoTrackManager.shared.locationManager = mockManager
-        manager = GeoTrackManager.shared as? GeoTrackManager
+        subject = GeoTrackManager.shared as? GeoTrackManager
         GeoTrackManager.shared.shouldStorePoints = true
         oldPointTimeThreshold = GeoTrackManager.oldPointTimeThreshold
 
-        XCTAssertNotNil(manager)
+        XCTAssertNotNil(subject)
     }
 
     override func tearDown() {
@@ -35,7 +35,7 @@ class GeoTrackManagerTests: XCTestCase {
     }
 
     func testFliteringAllPoints() {
-        guard let manager = manager else {
+        guard let manager = subject else {
             return XCTFail("cannot locate the manager")
         }
         GeoTrackManager.shared.pointFilter = .filterAllPoints
@@ -57,11 +57,11 @@ class GeoTrackManagerTests: XCTestCase {
     }
 
     func testFilteringDefaults() {
-        guard let manager = manager else {
+        guard let manager = subject else {
             return XCTFail("cannot locate the manager")
         }
         GeoTrackManager.shared.pointFilter = .defaultFilterOptions
-        GeoTrackManager.oldPointTimeThreshold = 0
+        GeoTrackManager.oldPointTimeThreshold = nil
 
         guard let points = TrackReader(bundleFilename: "reference-track-1").track?.points, points.count > 0 else {
             return XCTFail("no points")
@@ -75,6 +75,7 @@ class GeoTrackManagerTests: XCTestCase {
         manager.locationManager(locationServicing: mockManager, didChangeAuthorization: .authorizedWhenInUse)
         manager.locationManager(locationServicing: mockManager, didUpdateLocations: points)
 
+        XCTAssertNotNil(manager.track)
         XCTAssertNotEqual(0, manager.track?.points.count ?? 0)
         XCTAssertTrue((manager.track?.points.count ?? points.count) < points.count)
     }