Skip to content

add sort on cloud and access #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barbeek merged 3 commits into from
Aug 27, 2024
Merged

add sort on cloud and access #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c69932
add sort on cloud and access
Aug 27, 2024
9c5ae3c
Merge branch 'main' into feat/IOPR-4239
Aug 27, 2024
6889030
merge main
Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/data_sources/access_product_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,12 @@ func (d *accessProductDataSource) Read(ctx context.Context, req datasource.ReadR
resp.Diagnostics.AddError("error getting filters", err.Error())
}
filterStrings = append(filterStrings, filtersToAdd...)
sortStrings := getSortString(data.Sort)

// Define the search request
searchRequest := &meilisearch.SearchRequest{
Filter: filterStrings,
Sort: sortStrings,
Facets: []string{
"location",
"bandwidth",
Expand Down
2 changes: 2 additions & 0 deletions internal/data_sources/cloud_product_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,12 @@ func (d *cloudProductDataSource) Read(ctx context.Context, req datasource.ReadRe
if err != nil {
resp.Diagnostics.AddError("error getting filters", err.Error())
}
sortStrings := getSortString(data.Sort)

// Define the search request
searchRequest := &meilisearch.SearchRequest{
Filter: filtersStrings,
Sort: sortStrings,
Facets: []string{
"cspName",
"cspRegion",
Expand Down
3 changes: 0 additions & 3 deletions internal/data_sources/transport_product_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ func (d *transportProductDataSource) Read(ctx context.Context, req datasource.Re
resp.Diagnostics.AddError("error getting filters", err.Error())
}
sortStrings := getSortString(data.Sort)
if err != nil {
resp.Diagnostics.AddError("error getting sort", err.Error())
}

// Define the search request
searchRequest := &meilisearch.SearchRequest{
Expand Down