diff --git a/sycl/doc/design/CommandGraph.md b/sycl/doc/design/CommandGraph.md index 68592c9a933a8..b97ef36ad11a3 100644 --- a/sycl/doc/design/CommandGraph.md +++ b/sycl/doc/design/CommandGraph.md @@ -163,6 +163,9 @@ created on UR command-buffer enqueue. There is also a *WaitEvent* used by the `ur_exp_command_buffer_handle_t` class in the prefix to wait on any dependencies passed in the enqueue wait-list. +This WaitEvent is reset at the end of the suffix, along with reset commands +to reset the L0 events used to implement the UR sync-points back to the +non-signaled state. ![L0 command-buffer diagram](images/L0_UR_command-buffer.svg) diff --git a/sycl/doc/design/images/L0_UR_command-buffer.svg b/sycl/doc/design/images/L0_UR_command-buffer.svg index 133fa17b9d711..414abd90ba9d0 100644 --- a/sycl/doc/design/images/L0_UR_command-buffer.svg +++ b/sycl/doc/design/images/L0_UR_command-buffer.svg @@ -1,17 +1 @@ - - - - - - - - PrefixSuffixCommands added to UR command-buffer by userPrefix commandsReset SignalEventBarrier waiting on WaitEventSuffix commandsSignal the UR command-buffer SignalEvent \ No newline at end of file +PrefixCommands added to UR command-buffer by userSuffixResetSignalEventBarrier waiting onWaitEventBarrier waiting on UR command-buffer sync-point events, andSignalingthe UR command-bufferSignalEventPrefix commandsSuffix commandsResetWaitEventcommands toreset L0 eventused for sync-points \ No newline at end of file diff --git a/sycl/plugins/unified_runtime/CMakeLists.txt b/sycl/plugins/unified_runtime/CMakeLists.txt index 88b328e8daab4..6a102c0696186 100644 --- a/sycl/plugins/unified_runtime/CMakeLists.txt +++ b/sycl/plugins/unified_runtime/CMakeLists.txt @@ -54,13 +54,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT) include(FetchContent) set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") - # commit cf26de283a1233e6c93feb085acc10c566888b59 - # Merge: 3a3aae38 2fd9dea2 + # commit: 7c8617b3710736db642585fe310a64e19e059d2e + # Merge: 20d4f49 9a13af # Author: Kenneth Benzie (Benie) - # Date: Wed Oct 25 10:36:48 2023 +0100 - # Merge pull request #940 from Naghasan/victor/kernel-fusion-amd - # [UR][HIP] Enable kernel finalization using comgr - set(UNIFIED_RUNTIME_TAG cf26de283a1233e6c93feb085acc10c566888b59) + # Date: Thu Oct 26 10:20:03 2023 +0100 + # Merge pull request #965 from Bensuo/ewan/L0_internal_event_fix + # [Command-buffer][L0] Reset sync-point events + set(UNIFIED_RUNTIME_TAG 7c8617b3710736db642585fe310a64e19e059d2e) if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO) set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")