Skip to content

Commit 22db812

Browse files
author
Brendan Ryan
committed
cleanup
1 parent dabc0c4 commit 22db812

File tree

5 files changed

+4
-10
lines changed

5 files changed

+4
-10
lines changed

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ require (
1111
github.com/hashicorp/go-multierror v0.0.0-20180717150148-3d5d8f294aa0
1212
github.com/hashicorp/hcl v0.0.0-20180404174102-ef8a98b0bbce // indirect
1313
github.com/inconshreveable/mousetrap v1.0.0 // indirect
14-
github.com/logrusorgru/aurora v0.0.0-20190428105938-cea283e61946
1514
github.com/magiconair/properties v1.8.0 // indirect
1615
github.com/mattn/go-colorable v0.1.0 // indirect
1716
github.com/mattn/go-isatty v0.0.4 // indirect

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ github.com/hashicorp/hcl v0.0.0-20180404174102-ef8a98b0bbce h1:xdsDDbiBDQTKASoGE
1515
github.com/hashicorp/hcl v0.0.0-20180404174102-ef8a98b0bbce/go.mod h1:oZtUIOe8dh44I2q6ScRibXws4Ajl+d+nod3AaR9vL5w=
1616
github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM=
1717
github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8=
18-
github.com/logrusorgru/aurora v0.0.0-20190428105938-cea283e61946 h1:z+WaKrgu3kCpcdnbK9YG+JThpOCd1nU5jO5ToVmSlR4=
19-
github.com/logrusorgru/aurora v0.0.0-20190428105938-cea283e61946/go.mod h1:7rIyQOR62GCctdiQpZ/zOJlFyk6y+94wXzv6RNZgaR4=
2018
github.com/magiconair/properties v1.8.0 h1:LLgXmsheXeRoUOBOjtwPQCWIYqM/LU1ayDtDePerRcY=
2119
github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
2220
github.com/mattn/go-colorable v0.1.0 h1:v2XXALHHh6zHfYTJ+cSkwtyffnaOyR1MXaA91mTrb8o=

kubeval/output.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,23 @@ import (
77
// TODO (brendanryan) move these structs to `/log` once we have removed the potential
88
// circular dependancy between this package and `/log`
99

10-
// OutputManager controls how results of the `ccheck` evaluation will be recorded
10+
// OutputManager controls how results of the `kubeval` evaluation will be recorded
1111
// and reported to the end user.
1212
type OutputManager interface {
1313
Put(r ValidationResult) error
1414
Flush() error
1515
}
1616

17-
// STDOutputManager reports `ccheck` results to stdout.
17+
// STDOutputManager reports `kubeval` results to stdout.
1818
type STDOutputManager struct {
1919
}
2020

21-
// NewDefaultStdOutputManager instantiates a new instance of STDOutputManager using
22-
// the default logger.
21+
// NewSTDOutputManager instantiates a new instance of STDOutputManager.
2322
func NewSTDOutputManager() *STDOutputManager {
2423
return &STDOutputManager{}
2524
}
2625

2726
func (s *STDOutputManager) Put(result ValidationResult) error {
28-
2927
if len(result.Errors) > 0 {
3028
log.Warn("The file", result.FileName, "contains an invalid", result.Kind)
3129
for _, desc := range result.Errors {

log/log.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,3 @@ func Error(message ...interface{}) {
2424
red := color.New(color.FgRed)
2525
red.Println(message...)
2626
}
27-

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ func logResults(results []kubeval.ValidationResult, success bool) (bool, error)
119119
//// fetch output logger based on enviroments params -- for now we only support
120120
//// the stdout logger
121121
out := kubeval.NewSTDOutputManager()
122-
fmt.Println(out)
123122

124123
for _, result := range results {
125124
if len(result.Errors) > 0 {
@@ -130,6 +129,7 @@ func logResults(results []kubeval.ValidationResult, success bool) (bool, error)
130129
return success, err
131130
}
132131
}
132+
133133
return success, nil
134134
}
135135

0 commit comments

Comments
 (0)