Feature/printing labels #1725 and #1747 (#1746)

* enabled printing label

* isolate name blinded in every purposes

* removed apparently unnecessary logic of blinded columns on CSV

* put back specs

* generic blinded columns spec

* blinded specs on sample forms

* isolate name blinded in every purposes

* removed apparently unnecessary logic of blinded columns on CSV

* put back specs

* generic blinded columns spec

* blinded specs on sample forms

* blinded value on Samples index table

* fixed blinded value on label was breaking the line changed from div to span

* WIP: error when column wasnt blinded, but still there a 4 showing beside the field value

* fixed the haml to show correctly the value of isolate name column

* WIP: showing print label and ordering

* WIP: showing print label and ordering

* blinded ordered by uuid, unblided ordered by batch id, concentration, replicate and replicate column after concentration on CSV

* order in untransfered boxes

* adding comment and removing duplicated logic for blinded sample

* changed blinded columns position on box specs

* blinded I.N. on labels and changed I.M. to Purpose

* printing buttons on transfer details and ordering rules

* print button on transfer details

* specs ready for the changes

* removing debug from spec, blocking resending the same box, adjusting logic to query after boolean check

* spliting blueprints samples filled/overfilled and receiver_confirmed version of TransferPackage

* adding data to samples to check CSV rows order

* Fix Reviews

Remove unused CSS
Refactor Printing Buttons CSS Positioning
Refactor is_sender method using any? instead of present?
Refactor the way SamplePresenter map is used
Fix Showing Buttons Conditions
Refactor Executing is_sender just one time

* Fix load_box_print logic

* Remove TransferPackages from Printing Boxes

Removed it in controllers, haml links and specs

* Fix Sample Map has a remaining }

* Fix Sample Map has a remaining }

* Refactor Print and Inventory Code

Improved sender verification, authorize resource and Add
Specs to verify if multiple transfers are blocked

* Fix Load Box Samples Reassigning Samples

samples.scrambled needs to be reassigned the order
of samples was wrong on CSV inventory

* Fix Confirmed Box Specs

Confirmed Box Specs impacted the index spec

* Fix force_unblind Verification

Changed the sintax of force_unblind verification.

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

* Refactor The Way to Execute load_box Before Action

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

* Fix load_box before_action

* Refator before_action loadbox

* Remove delete method on load_box before_action

Co-authored-by: Carlos Zillner <cz@rock.com.br>
Co-authored-by: Johannes Müller <straightshoota@gmail.com>

Author: 3 people

app/assets/stylesheets/_barcode_card.scss

@@ -10,7 +10,7 @@
 
     background: $white;
     padding: 5px 7px;
-    margin: 15px 15px 7px;
+    margin: 15px 15px;
 
     .title {
       font-size: 14px;
@@ -66,17 +66,6 @@
   }
 }
 
-.barcode-after {
-  margin: 7px 15px 0;
-
-  .btn-icon {
-    margin: -3px 0 0;
-    font-size: 24px;
-    background: none !important;
-    color: inherit;
-  }
-}
-
 // Print Barcode style
 
 .barcode-card-print {

app/assets/stylesheets/_box_preview.scss

@@ -1,20 +1,39 @@
 .box-preview {
   display: grid;
   grid-template-areas:
-      "uuid uuid uuid uuid uuid"
-      "data data data data data";
-  grid-template-columns: auto 1fr auto;
+      "uuid uuid uuid btns"
+      "purpose samples time btns";
+  grid-template-columns: auto auto auto 1fr;
   grid-gap: 5px;
 
   .box__uuid {
     font-weight: bold;
     margin-right: 15px;
     grid-area: uuid;
+    padding-top: 8px;
 
     > a {
       color: inherit;
     }
   }
+  .box__btns {
+    grid-area: btns;
+    display: flex;
+    flex-direction: column;
+    align-items: flex-end;
+  }
+  .box__created_at {
+    grid-area: time;
+  }
+  .box__purpose {
+    grid-area: purpose;
+  }
+  .box__samples {
+    grid-area: samples;
+  }
+  .btn-link {
+    display: block;
+  }
 }
 
 .qc-info-message {

app/controllers/boxes_controller.rb

@@ -1,5 +1,6 @@
 class BoxesController < ApplicationController
-  before_action :load_box, except: %i[index new create bulk_destroy]
+  before_action :load_box, only: %i[show destroy]
+  before_action :load_box_print, only: %i[print inventory]
   helper_method :samples_data
 
   def index
@@ -22,9 +23,9 @@ def show
   end
 
   def inventory
-    return unless authorize_resource(@box, READ_BOX)
+    return unless authorize_resource( box_resource(@box), READ_BOX )
 
-    @samples = load_box_samples
+    @samples = load_box_samples( sender? )
 
     respond_to do |format|
       format.csv do
@@ -34,14 +35,16 @@ def inventory
   end
 
   def print
-    return unless authorize_resource(@box, READ_BOX)
+    return unless authorize_resource( box_resource(@box), READ_BOX )
+
+    @samples = load_box_samples
 
     render pdf: "cdx_box_#{@box.uuid}",
       template: "boxes/print.pdf",
       layout: "layouts/pdf.html",
       locals: {
         box: @box,
-        samples: @box.samples.preload(:batch, :sample_identifiers),
+        samples: @samples,
       },
       margin: { top: 0, bottom: 0, left: 0, right: 0 },
       page_width: "1in",
@@ -100,10 +103,36 @@ def load_box
     end
   end
 
-  def load_box_samples
+  def load_box_print
+    @box = Box.where(institution: @navigation_context.institution, id: params.fetch(:id)).take
+    if @box.nil?
+      @box = Box
+        .joins(box_transfers: :transfer_package)
+        .merge( TransferPackage.within( @navigation_context.institution ) )
+        .where(id: params.fetch(:id))
+        .take
+    end
+  end
+
+  def load_box_samples( force_unblind = false )
     samples = @box.samples.preload(:batch, :sample_identifiers)
-    samples = samples.scrambled if @box.blinded?
-    SamplePresenter.map(samples, request.format)
+    if !@box.blinded or sender?
+      samples = samples.sort_by{ |sample| [sample.batch_number, sample.concentration, sample.replicate ] }
+    else
+      samples = samples.scrambled
+    end
+    unless force_unblind
+      samples = SamplePresenter.map(samples, request.format)
+    end
+    samples
+  end
+
+  def sender?
+    return @sender unless @sender.nil?
+    @sender = BoxTransfer
+      .joins(:transfer_package)
+      .where( box_id: params.fetch(:id), transfer_packages: { sender_institution_id: @navigation_context.institution } )
+      .exists?
   end
 
   def load_batches
@@ -139,4 +168,16 @@ def samples_data(samples)
       }
     end
   end
+
+  def box_resource(box)
+    return box if box.institution_id == @navigation_context.institution.id || !sender?
+
+    # the box is being transferred or the user is the sender:
+    {
+      resource_type: "box",
+      resource_id: box.id,
+      institution_id: @navigation_context.institution.id,
+      site_id: @navigation_context.site.try(&:uuid),
+    }
+  end
 end

app/controllers/samples_controller.rb

@@ -30,7 +30,7 @@ def index
     @samples = perform_pagination(@samples)
       .preload(:batch, :sample_identifiers)
 
-    @samples = @samples.map { |sample|  SamplePresenter.new(sample, request.format ) }
+    @samples = SamplePresenter.map(@samples, request.format )
   end
 
   def autocomplete
@@ -119,6 +119,7 @@ def print
     @sample = Sample.find(params[:id])
     return unless authorize_resource(@sample, READ_SAMPLE)
 
+    @sample = SamplePresenter.new(@sample, request.format)
     render pdf: "cdx_sample_#{@sample.uuid}",
       template: "samples/barcode.pdf",
       layout: "layouts/pdf.html",

app/controllers/transfer_packages_controller.rb

@@ -36,7 +36,7 @@ def show
       .within(@navigation_context.institution)
       .includes(:box_transfers, :boxes)
       .find(params[:id])
-
+    @show_print_buttons = true
     @transfer_package = TransferPackagePresenter.new(transfer_package, @navigation_context)
 
     @view_helper = view_helper({ save_back_path: true })
@@ -76,8 +76,10 @@ def find_box
     full_uuid = uuid.size == 36
     @boxes = Box
       .within(@navigation_context.entity, @navigation_context.exclude_subsites)
+      .left_joins(:box_transfers)
+      .where(box_transfers: {id: nil})
       .autocomplete(uuid)
-      .order("created_at DESC")
+      .order("boxes.created_at DESC")
       .count_samples
       .limit(5)
 

app/views/boxes/_barcode_card.haml

@@ -12,10 +12,3 @@
     .logo
       = image_tag 'cdx-logo-bw.png'
       .label https://cdx.io
-
-
-  .row.actions
-    - unless @box.blinded?
-      = link_to print_box_path(@box), target: "_blank", class: 'btn-link' do
-        .icon-print.btn-icon
-        %span Print box and sample labels

app/views/boxes/_preview.haml

@@ -1,10 +1,22 @@
 .box-preview
   .box__uuid{title: "UUID"}
     = box.uuid
+
+  .box__created_at{title: "Creation date"}
+    = time_tag box.created_at, I18n.l(box.created_at, format: I18n.t("date.formats.long"))
+
   .box__purpose{title: "Purpose"}
     = box.purpose
   .box__samples{title: "Samples"}
     = box.samples_count
     samples
-  .box__created_at{title: "Creation date"}
-    = time_tag box.created_at, I18n.l(box.created_at, format: I18n.t("date.formats.long"))
+
+  .box__btns{title: "Actions"}
+    - if @show_print_buttons and !@can_confirm
+      = link_to print_box_path(box), target: "_blank", class: 'btn-link' do
+        .icon-print.btn-icon
+        %span Print box and sample labels
+
+      = link_to inventory_box_path(box, format: "csv"), target: "_blank", class: 'btn-link' do
+        .icon-download.btn-icon
+        %span Download inventory

app/views/boxes/inventory.csv.csvbuilder

@@ -4,9 +4,9 @@ csv << [
   "Label ID (QR code)",
   "Batch ID",
   "Virus Lineage",
-  "Replicate",
   "Production Date",
   "Concentration",
+  "Replicate",
   "Inactivation Method",
   "Media",
 ]
@@ -18,9 +18,9 @@ csv << [
     sample.uuid,
     sample.batch_number,
     sample.virus_lineage,
-    sample.replicate,
     sample.date_produced.to_date,
     sample.concentration_formula,
+    sample.replicate,
     sample.inactivation_method,
     sample.media,
   ]

app/views/boxes/show.haml

@@ -30,11 +30,6 @@
       .col
         = render "barcode_card"
 
-        .barcode-after
-          = link_to inventory_box_path(@box, format: "csv"), target: "_blank", class: 'btn-link' do
-            .icon-download.btn-icon
-            %span Download inventory
-
 .row
   .col
     .row

app/views/samples/barcode.pdf.haml

@@ -9,8 +9,12 @@
         #{sample.uuid}
     .code
       I.N. #{sample.isolate_name}
-    .code
-      I.M. #{sample.inactivation_method}
+    - if sample.box
+      .code
+        Purpose: #{sample.box.purpose}
+    - else
+      .code
+        I.M. #{sample.inactivation_method}
     .code
       P.D. #{sample.date_produced_description}
     .logo