Skip to content

Commit daa4874

Browse files
saintstackGuanghao Zhang
authored andcommitted
HBASE-23956 Use less resources running tests (apache#1266) Addendum: This test was depending on hard-coded number for log cleaners; the parent patch made them less in test context.
1 parent 11fe2fe commit daa4874

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ public void testOnConfigurationChange() throws Exception {
303303

304304
FileSystem fs = TEST_UTIL.getDFSCluster().getFileSystem();
305305
LogCleaner cleaner = new LogCleaner(3000, server, conf, fs, OLD_WALS_DIR, POOL);
306-
assertEquals(LogCleaner.DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE, cleaner.getSizeOfCleaners());
306+
int size = cleaner.getSizeOfCleaners();
307307
assertEquals(LogCleaner.DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC,
308308
cleaner.getCleanerThreadTimeoutMsec());
309309
// Create dir and files for test
@@ -318,10 +318,10 @@ public void testOnConfigurationChange() throws Exception {
318318
// change size of cleaners dynamically
319319
int sizeToChange = 4;
320320
long threadTimeoutToChange = 30 * 1000L;
321-
conf.setInt(LogCleaner.OLD_WALS_CLEANER_THREAD_SIZE, sizeToChange);
321+
conf.setInt(LogCleaner.OLD_WALS_CLEANER_THREAD_SIZE, size + sizeToChange);
322322
conf.setLong(LogCleaner.OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC, threadTimeoutToChange);
323323
cleaner.onConfigurationChange(conf);
324-
assertEquals(sizeToChange, cleaner.getSizeOfCleaners());
324+
assertEquals(sizeToChange + size, cleaner.getSizeOfCleaners());
325325
assertEquals(threadTimeoutToChange, cleaner.getCleanerThreadTimeoutMsec());
326326
// Stop chore
327327
thread.join();

0 commit comments

Comments
 (0)