Verify Header in Wasm light client

light-client/Cargo.toml

@@ -61,6 +61,8 @@ ibc-client-starknet       = { path = "./ibc-client-starknet" }
 ibc-client-starknet-cw    = { path = "./ibc-client-starknet-cw" }
 ibc-client-starknet-types = { path = "./ibc-client-starknet-types" }
 
+ibc-client-cw = { git = "https://github.com/informalsystems/cosmwasm-ibc.git", branch = "luca_joss/add-cw-client-extension-trait" }
+
 cgp                     = { git = "https://github.com/contextgeneric/cgp.git" }
 cgp-core                = { git = "https://github.com/contextgeneric/cgp.git" }
 cgp-extra               = { git = "https://github.com/contextgeneric/cgp.git" }

light-client/ibc-client-starknet-types/src/client_state.rs

@@ -9,4 +9,5 @@ pub const STARKNET_CLIENT_STATE_TYPE_URL: &str = "/StarknetClientState";
 pub struct StarknetClientState {
     pub latest_height: Height,
     pub chain_id: ChainId,
+    pub pub_key: Vec<u8>,
 }

light-client/ibc-client-starknet-types/src/encoding/components.rs

@@ -22,7 +22,9 @@ use ibc_core::primitives::Timestamp;
 use crate::encoding::impls::client_state::EncodeStarknetClientState;
 use crate::encoding::impls::consensus_state::EncodeStarknetConsensusState;
 use crate::encoding::impls::header::{EncodeSignedStarknetHeader, EncodeStarknetHeader};
-use crate::header::{SignedStarknetHeader, StarknetHeader, STARKNET_HEADER_TYPE_URL};
+use crate::header::{
+    SignedStarknetHeader, StarknetHeader, SIGNED_STARKNET_HEADER_TYPE_URL, STARKNET_HEADER_TYPE_URL,
+};
 use crate::{
     StarknetClientState, StarknetConsensusState, STARKNET_CLIENT_STATE_TYPE_URL,
     STARKNET_CONSENSUS_STATE_TYPE_URL,
@@ -145,5 +147,5 @@ impl_type_url!(
 impl_type_url!(
     StarknetLightClientTypeUrlSchemas,
     SignedStarknetHeader,
-    STARKNET_HEADER_TYPE_URL,
+    SIGNED_STARKNET_HEADER_TYPE_URL,
 );

light-client/ibc-client-starknet-types/src/encoding/impls/client_state.rs

@@ -6,6 +6,7 @@ use hermes_encoding_components::impls::encode_mut::field::EncodeField;
 use hermes_encoding_components::impls::encode_mut::from::DecodeFrom;
 use hermes_encoding_components::traits::transform::Transformer;
 use hermes_protobuf_encoding_components::components::{MutDecoderComponent, MutEncoderComponent};
+use hermes_protobuf_encoding_components::impls::encode_mut::proto_field::bytes::EncodeByteField;
 use hermes_protobuf_encoding_components::impls::encode_mut::proto_field::decode_required::DecodeRequiredProtoField;
 use hermes_protobuf_encoding_components::impls::encode_mut::proto_field::encode::EncodeLengthDelimitedProtoField;
 use ibc_core::client::types::Height;
@@ -27,26 +28,32 @@ delegate_components! {
                     symbol!("chain_id"),
                     EncodeChainIdField<2>,
                 >,
+                EncodeField<
+                    symbol!("pub_key"),
+                    EncodeByteField<3>,
+                >,
             ]>,
         MutDecoderComponent: DecodeFrom<
             Self,
             CombineEncoders<Product![
                 DecodeRequiredProtoField<1, UseContext>,
                 EncodeChainIdField<2>,
+                EncodeByteField<3>,
             ]>
         >,
     }
 }
 
 impl Transformer for EncodeStarknetClientState {
-    type From = Product![Height, ChainId];
+    type From = Product![Height, ChainId, Vec<u8>];
 
     type To = StarknetClientState;
 
-    fn transform(product![latest_height, chain_id]: Self::From) -> Self::To {
+    fn transform(product![latest_height, chain_id, pub_key]: Self::From) -> Self::To {
         StarknetClientState {
             latest_height,
             chain_id,
+            pub_key,
         }
     }
 }

light-client/ibc-client-starknet-types/src/encoding/impls/header.rs

@@ -59,7 +59,7 @@ delegate_components! {
             CombineEncoders<Product![
                 EncodeField<
                     symbol!("header"),
-                    EncodeLengthDelimitedProtoField<1, UseContext>,
+                    EncodeByteField<1>,
                 >,
                 EncodeField<
                     symbol!("signature"),
@@ -69,15 +69,15 @@ delegate_components! {
         MutDecoderComponent: DecodeFrom<
             Self,
             CombineEncoders<Product![
-                DecodeRequiredProtoField<1, UseContext>,
+                EncodeByteField<1>,
                 EncodeByteField<2>,
             ]>
         >,
     }
 }
 
 impl Transformer for EncodeSignedStarknetHeader {
-    type From = Product![StarknetHeader, Vec<u8>];
+    type From = Product![Vec<u8>, Vec<u8>];
 
     type To = SignedStarknetHeader;
 

light-client/ibc-client-starknet-types/src/header.rs

@@ -4,6 +4,7 @@ use ibc_core::client::types::Height;
 use crate::StarknetConsensusState;
 
 pub const STARKNET_HEADER_TYPE_URL: &str = "/StarknetHeader";
+pub const SIGNED_STARKNET_HEADER_TYPE_URL: &str = "/SignedStarknetHeader";
 
 #[derive(Debug, Clone, HasField)]
 pub struct StarknetHeader {
@@ -13,6 +14,6 @@ pub struct StarknetHeader {
 
 #[derive(Debug, Clone, HasField)]
 pub struct SignedStarknetHeader {
-    pub header: StarknetHeader,
+    pub header: Vec<u8>,
     pub signature: Vec<u8>,
 }

light-client/ibc-client-starknet/Cargo.toml

@@ -27,6 +27,7 @@ hermes-cosmos-encoding-components   = { workspace = true }
 # ibc dependencies
 ibc-core                  = { workspace = true }
 ibc-client-starknet-types = { workspace = true }
+ibc-client-cw             = { workspace = true }
 
 [features]
 default = [ "std" ]

light-client/ibc-client-starknet/src/client_state/execution.rs

@@ -2,7 +2,10 @@ use cgp::core::component::UseContext;
 use hermes_cosmos_encoding_components::impls::any::ConvertIbcAny;
 use hermes_encoding_components::impls::convert::ConvertVia;
 use hermes_encoding_components::traits::convert::Converter;
-use ibc_client_starknet_types::header::SignedStarknetHeader;
+use hermes_encoding_components::traits::decode::CanDecode;
+use hermes_protobuf_encoding_components::types::strategy::ViaProtobuf;
+use ibc_client_cw::context::client_ctx::CwClientExecution;
+use ibc_client_starknet_types::header::{SignedStarknetHeader, StarknetHeader};
 use ibc_client_starknet_types::StarknetClientState as ClientStateType;
 use ibc_core::client::context::client_state::ClientStateExecution;
 use ibc_core::client::context::prelude::{ClientStateCommon, ConsensusState};
@@ -18,9 +21,10 @@ use super::ClientState;
 use crate::encoding::context::StarknetLightClientEncoding;
 use crate::ConsensusState as StarknetConsensusState;
 
-impl<E> ClientStateExecution<E> for ClientState
+impl<'a, E> ClientStateExecution<E> for ClientState
 where
-    E: ClientExecutionContext<
+    E: CwClientExecution<
+        'a,
         ClientStateMut = ClientState,
         ConsensusStateRef = StarknetConsensusState,
     >,
@@ -56,7 +60,37 @@ where
                 &header,
             )?;
 
-        let header = signed_header.header;
+        let raw_header = signed_header.header;
+
+        let header_digest = ctx.generate_sha256_digest(&raw_header);
+
+        let deps = ctx
+            .cosmwasm_execute_context()
+            .ok_or_else(|| ClientError::ClientSpecific {
+                description: "missing Deps from context".to_owned(),
+            })?;
+
+        match deps.api.secp256k1_verify(
+            header_digest.as_slice(),
+            &signed_header.signature,
+            &self.0.pub_key,
+        ) {
+            Ok(validation) if validation => {}
+            Ok(_) => {
+                return Err(ClientError::ClientSpecific {
+                    description: "Header signature not valid".to_owned(),
+                })
+            }
+            Err(e) => {
+                return Err(ClientError::ClientSpecific {
+                    description: format!("Header signature verification failed:{e} "),
+                })
+            }
+        }
+        let header: StarknetHeader = <StarknetLightClientEncoding as CanDecode<
+            ViaProtobuf,
+            StarknetHeader,
+        >>::decode(&StarknetLightClientEncoding, &raw_header)?;
 
         let latest_height = header.height;
 
@@ -65,6 +99,7 @@ where
         let new_client_state = ClientStateType {
             latest_height: header.height,
             chain_id: self.0.chain_id.clone(),
+            pub_key: self.0.pub_key.clone(),
         }
         .into();
 

light-client/ibc-client-starknet/src/client_state/validation.rs

@@ -1,5 +1,5 @@
+use ibc_client_cw::context::client_ctx::CwClientValidation;
 use ibc_core::client::context::client_state::ClientStateValidation;
-use ibc_core::client::context::ClientValidationContext;
 use ibc_core::client::types::error::ClientError;
 use ibc_core::client::types::Status;
 use ibc_core::host::types::identifiers::ClientId;
@@ -8,9 +8,9 @@ use ibc_core::primitives::proto::Any;
 use super::ClientState;
 use crate::ConsensusState;
 
-impl<V> ClientStateValidation<V> for ClientState
+impl<'a, V> ClientStateValidation<V> for ClientState
 where
-    V: ClientValidationContext<ClientStateRef = ClientState, ConsensusStateRef = ConsensusState>,
+    V: CwClientValidation<'a, ClientStateRef = ClientState, ConsensusStateRef = ConsensusState>,
 {
     fn verify_client_message(
         &self,

nix/ibc-starknet-cw.nix

@@ -12,6 +12,7 @@ let
       outputHashes = {
         "hermes-cosmos-encoding-components-0.1.0" = "sha256-V1TlMnVHBwlSBJmB9gSJV/BgUTy7S0yhrtn3anZyorU=";
         "cgp-0.3.1" = "sha256-AOQ+WVQWPlF2ZfYYc5Eq3t7XAljd5P2qExWLYZWNnd8=";
+        "ibc-client-cw-0.56.0" = "sha256-EkLxuJfr3vf0busmSZD7DwOS9GfgfhT+sdopi1nNiCs=";
       };
     };
 

relayer/Cargo.toml

@@ -35,6 +35,7 @@ starknet-types-core         = { version = "0.1.7" }
 url                         = { version = "2.4.0" }
 eyre                        = { version = "0.6.12" }
 tokio                       = { version = "1.38" }
+secp256k1                   = { version = "0.28.2" }
 serde                       = { version = "1.0" }
 serde_json                  = { version = "1.0" }
 rand                        = { version = "0.8.5" }

relayer/crates/starknet-chain-components/Cargo.toml

@@ -32,8 +32,10 @@ cairo-lang-starknet-classes = { workspace = true }
 http                        = { workspace = true }
 ibc-client-starknet-types   = { workspace = true }
 prost-types                 = { workspace = true }
+secp256k1                   = { workspace = true }
 serde                       = { workspace = true }
 serde_json                  = { workspace = true }
+sha2                        = { workspace = true }
 starknet                    = { workspace = true }
 tonic                       = { workspace = true }
 futures                     = { workspace = true }

relayer/crates/starknet-chain-components/src/components/starknet_to_cosmos.rs

@@ -28,6 +28,7 @@ use hermes_relayer_components::chain::traits::queries::consensus_state::{
 use crate::impls::starknet_to_cosmos::channel_message::BuildStarknetToCosmosChannelHandshakeMessage;
 use crate::impls::starknet_to_cosmos::connection_message::BuildStarknetToCosmosConnectionHandshake;
 use crate::impls::starknet_to_cosmos::counterparty_message_height::GetCosmosCounterpartyMessageStarknetHeight;
+use crate::impls::starknet_to_cosmos::create_client_message::BuildStarknetCreateClientMessage;
 use crate::impls::starknet_to_cosmos::packet_fields::ReadPacketDstStarknetFields;
 use crate::impls::starknet_to_cosmos::query_consensus_state_height::QueryStarknetConsensusStateHeightsFromGrpc;
 use crate::impls::starknet_to_cosmos::update_client_message::BuildStarknetUpdateClientMessage;
@@ -46,11 +47,12 @@ cgp_preset! {
             CreateClientPayloadTypeComponent,
             CreateClientMessageOptionsTypeComponent,
             CreateClientPayloadOptionsTypeComponent,
-            CreateClientMessageBuilderComponent,
             CreateClientPayloadBuilderComponent,
             ChannelOpenInitMessageBuilderComponent,
         ]:
             CosmosToCosmosComponents,
+        CreateClientMessageBuilderComponent:
+            BuildStarknetCreateClientMessage,
         [
             ClientStateTypeComponent,
             ClientStateFieldsComponent,

relayer/crates/starknet-chain-components/src/impls/payload_builders/create_client.rs

@@ -10,7 +10,6 @@ use ibc::core::client::types::Height;
 use ibc::core::host::types::identifiers::ChainId;
 use ibc::primitives::Timestamp;
 
-use crate::types::client_state::{StarknetClientState, WasmStarknetClientState};
 use crate::types::consensus_state::{StarknetConsensusState, WasmStarknetConsensusState};
 use crate::types::payloads::client::{
     StarknetCreateClientPayload, StarknetCreateClientPayloadOptions,
@@ -38,14 +37,6 @@ where
 
         let root = Vec::from(chain_status.block_hash.to_bytes_be());
 
-        let client_state = WasmStarknetClientState {
-            wasm_code_hash: create_client_options.wasm_code_hash.into(),
-            client_state: StarknetClientState {
-                latest_height: Height::new(0, 1).map_err(Chain::raise_error)?,
-                chain_id: chain.chain_id().clone(),
-            },
-        };
-
         let consensus_state = WasmStarknetConsensusState {
             consensus_state: StarknetConsensusState {
                 root: root.into(),
@@ -54,7 +45,9 @@ where
         };
 
         Ok(StarknetCreateClientPayload {
-            client_state,
+            latest_height: Height::new(0, 1).map_err(Chain::raise_error)?,
+            chain_id: chain.chain_id().clone(),
+            client_state_wasm_code_hash: create_client_options.wasm_code_hash.into(),
             consensus_state,
         })
     }